You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/01/14 05:13:26 UTC
[GitHub] [iceberg] jackye1995 opened a new pull request #2088: Core: rename HIVE related catalog properties before release
jackye1995 opened a new pull request #2088:
URL: https://github.com/apache/iceberg/pull/2088
the ongoing work in JDBC catalog #1870 also uses the Hive catalog properties. So it does not make sense to have HIVE prefix for them. Remove those prefix before the initial release for `CatalogProperties`, it will be difficult to change it after released.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #2088: Core: rename HIVE related catalog properties before release
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #2088:
URL: https://github.com/apache/iceberg/pull/2088#issuecomment-764061396
Closing was accidental. Sorry about that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #2088: Core: rename HIVE related catalog properties before release
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #2088:
URL: https://github.com/apache/iceberg/pull/2088#issuecomment-764061172
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #2088: Core: rename HIVE related catalog properties before release
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #2088:
URL: https://github.com/apache/iceberg/pull/2088#issuecomment-764061172
+1
Will merge when tests pass.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue closed pull request #2088: Core: rename HIVE related catalog properties before release
Posted by GitBox <gi...@apache.org>.
rdblue closed pull request #2088:
URL: https://github.com/apache/iceberg/pull/2088
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rymurr commented on pull request #2088: Core: rename HIVE related catalog properties before release
Posted by GitBox <gi...@apache.org>.
rymurr commented on pull request #2088:
URL: https://github.com/apache/iceberg/pull/2088#issuecomment-760065537
LGTM! Thanks @jackye1995
I have raised #2090 to propagate this change to Nessie
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue merged pull request #2088: Core: rename HIVE related catalog properties before release
Posted by GitBox <gi...@apache.org>.
rdblue merged pull request #2088:
URL: https://github.com/apache/iceberg/pull/2088
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue merged pull request #2088: Core: rename HIVE related catalog properties before release
Posted by GitBox <gi...@apache.org>.
rdblue merged pull request #2088:
URL: https://github.com/apache/iceberg/pull/2088
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue closed pull request #2088: Core: rename HIVE related catalog properties before release
Posted by GitBox <gi...@apache.org>.
rdblue closed pull request #2088:
URL: https://github.com/apache/iceberg/pull/2088
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org