You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2020/09/08 18:11:19 UTC
[GitHub] [commons-beanutils] melloware opened a new pull request #39: Spotless Formatter and License Header Check
melloware opened a new pull request #39:
URL: https://github.com/apache/commons-beanutils/pull/39
Eclipse formatter which follows all the CheckStyle and Apache Commons guidelines for formatting. 4 Spaces, 120 line limit, proper whitespace handling etc.
Window->Preferences->Java->Code Style->Formatter and then press the Import button.
Point to eclipse-apache-formatter.xml.
You can format the entire project in one shot by right clicking on the package org.apache.commons.beanutils2 and selecting Source->Format.
OR...
Run `mvn spotless:check` or `mvn spotless:apply` to either format code or validate the format.
@aherbert I turned OFF all Javadoc formatting and now this looks much better. its not perfect but I don't know if there is a perfect formatter out there. This is to get the project in a good starting state for 2.0.0 release.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-beanutils] aherbert commented on pull request #39: Spotless Formatter and License Header Check
Posted by GitBox <gi...@apache.org>.
aherbert commented on pull request #39:
URL: https://github.com/apache/commons-beanutils/pull/39#issuecomment-689059867
The pom.xml formatting was a mess. I have reformatted it in master to remove tabs and use 2 spaces for the indent. Can you rebase so only the changes you have made show up in the diffs?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-beanutils] melloware commented on pull request #39: Spotless Formatter and License Header Check
Posted by GitBox <gi...@apache.org>.
melloware commented on pull request #39:
URL: https://github.com/apache/commons-beanutils/pull/39#issuecomment-689061977
Yeah it was a mess that is why I formatted it for 4 spaces which I thought was Apache standard?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-beanutils] melloware commented on pull request #39: Spotless Formatter and License Header Check
Posted by GitBox <gi...@apache.org>.
melloware commented on pull request #39:
URL: https://github.com/apache/commons-beanutils/pull/39#issuecomment-689068835
OK pom.xml has been fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org