[GitHub] [hudi] leesf commented on a diff in pull request #9287: [HUDI-6592] Flink insert overwrite should support dynamic partition instead of whole table

["leesf (via GitHub)" <gi...@apache.org>]

leesf commented on code in PR #9287:
URL: https://github.com/apache/hudi/pull/9287#discussion_r1276981957


##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/table/HoodieTableSink.java:
##########
@@ -145,18 +145,12 @@ public String asSummaryString() {
 
   @Override
   public void applyStaticPartition(Map<String, String> partitions) {
-    // #applyOverwrite should have been invoked.
-    if (this.overwrite && partitions.size() > 0) {
-      this.conf.setString(FlinkOptions.OPERATION, WriteOperationType.INSERT_OVERWRITE.value());
-    }
   }
 
   @Override
   public void applyOverwrite(boolean overwrite) {
     this.overwrite = overwrite;
-    // set up the operation as INSERT_OVERWRITE_TABLE first,
-    // if there are explicit partitions, #applyStaticPartition would overwrite the option.
-    this.conf.setString(FlinkOptions.OPERATION, WriteOperationType.INSERT_OVERWRITE_TABLE.value());
+    this.conf.setString(FlinkOptions.OPERATION, WriteOperationType.INSERT_OVERWRITE.value());

Review Comment:
   for spark, the insert overwrite would be insert overwrite table/partition(insert overwrite xxx select xxx from / insert overwrite xxx partition(xx) select xxx from), is the same for flink? It was insert overwrite partition in hudi for spark by default even for insert overwrite xxx select xxx from, considering there are some users already using this feature and maintain compatibility, should be introduced a new config? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org