You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2015/07/23 19:55:32 UTC
Review Request 36735: Model DockerParameter in the database.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36735/
-----------------------------------------------------------
Review request for Aurora and Kevin Sweeney.
Bugs: AURORA-1407
https://issues.apache.org/jira/browse/AURORA-1407
Repository: aurora
Description
-------
Model DockerParameter in the database.
Diffs
-----
src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java c16aa4ccaf021f9da1f02fe2718e6c3a1dc63142
src/main/java/org/apache/aurora/scheduler/storage/db/TaskConfigManager.java 30a258aae69efc5ddb21cdfc06e85d19f0a19cd6
src/main/java/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.java 48f19045885d82e8fb702949b3e64e86e97a6a8b
src/main/resources/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.xml bbd67133ef19255e80d7910bac922020d1b917ba
src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql 52494afbb00e799e58ed9d76de56b70767ed0fda
src/test/java/org/apache/aurora/scheduler/storage/testing/StorageEntityUtil.java 0bde4d8bab3a2ad09e53d024dd5c76b7fcbf3083
Diff: https://reviews.apache.org/r/36735/diff/
Testing
-------
Thanks,
Bill Farner
Re: Review Request 36735: Model DockerParameter in the database.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36735/#review92780
-----------------------------------------------------------
src/test/java/org/apache/aurora/scheduler/storage/testing/StorageEntityUtil.java (lines 56 - 61)
<https://reviews.apache.org/r/36735/#comment147023>
This is the bit that i added to trip up unit tests. I could write a specific regression test for this case, but i feel this is a wider net.
- Bill Farner
On July 23, 2015, 5:57 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36735/
> -----------------------------------------------------------
>
> (Updated July 23, 2015, 5:57 p.m.)
>
>
> Review request for Aurora and Kevin Sweeney.
>
>
> Bugs: AURORA-1407
> https://issues.apache.org/jira/browse/AURORA-1407
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Model DockerParameter in the database.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java c16aa4ccaf021f9da1f02fe2718e6c3a1dc63142
> src/main/java/org/apache/aurora/scheduler/storage/db/TaskConfigManager.java 30a258aae69efc5ddb21cdfc06e85d19f0a19cd6
> src/main/java/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.java 48f19045885d82e8fb702949b3e64e86e97a6a8b
> src/main/resources/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.xml bbd67133ef19255e80d7910bac922020d1b917ba
> src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql 52494afbb00e799e58ed9d76de56b70767ed0fda
> src/test/java/org/apache/aurora/scheduler/storage/testing/StorageEntityUtil.java 0bde4d8bab3a2ad09e53d024dd5c76b7fcbf3083
>
> Diff: https://reviews.apache.org/r/36735/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 36735: Model DockerParameter in the database.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36735/#review92783
-----------------------------------------------------------
Ship it!
Master (eee70d6) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On July 23, 2015, 5:57 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36735/
> -----------------------------------------------------------
>
> (Updated July 23, 2015, 5:57 p.m.)
>
>
> Review request for Aurora and Kevin Sweeney.
>
>
> Bugs: AURORA-1407
> https://issues.apache.org/jira/browse/AURORA-1407
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Model DockerParameter in the database.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java c16aa4ccaf021f9da1f02fe2718e6c3a1dc63142
> src/main/java/org/apache/aurora/scheduler/storage/db/TaskConfigManager.java 30a258aae69efc5ddb21cdfc06e85d19f0a19cd6
> src/main/java/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.java 48f19045885d82e8fb702949b3e64e86e97a6a8b
> src/main/resources/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.xml bbd67133ef19255e80d7910bac922020d1b917ba
> src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql 52494afbb00e799e58ed9d76de56b70767ed0fda
> src/test/java/org/apache/aurora/scheduler/storage/testing/StorageEntityUtil.java 0bde4d8bab3a2ad09e53d024dd5c76b7fcbf3083
>
> Diff: https://reviews.apache.org/r/36735/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 36735: Model DockerParameter in the database.
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36735/#review92781
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Sweeney
On July 23, 2015, 10:57 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36735/
> -----------------------------------------------------------
>
> (Updated July 23, 2015, 10:57 a.m.)
>
>
> Review request for Aurora and Kevin Sweeney.
>
>
> Bugs: AURORA-1407
> https://issues.apache.org/jira/browse/AURORA-1407
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Model DockerParameter in the database.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java c16aa4ccaf021f9da1f02fe2718e6c3a1dc63142
> src/main/java/org/apache/aurora/scheduler/storage/db/TaskConfigManager.java 30a258aae69efc5ddb21cdfc06e85d19f0a19cd6
> src/main/java/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.java 48f19045885d82e8fb702949b3e64e86e97a6a8b
> src/main/resources/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.xml bbd67133ef19255e80d7910bac922020d1b917ba
> src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql 52494afbb00e799e58ed9d76de56b70767ed0fda
> src/test/java/org/apache/aurora/scheduler/storage/testing/StorageEntityUtil.java 0bde4d8bab3a2ad09e53d024dd5c76b7fcbf3083
>
> Diff: https://reviews.apache.org/r/36735/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 36735: Model DockerParameter in the database.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36735/
-----------------------------------------------------------
(Updated July 23, 2015, 5:57 p.m.)
Review request for Aurora and Kevin Sweeney.
Bugs: AURORA-1407
https://issues.apache.org/jira/browse/AURORA-1407
Repository: aurora
Description
-------
Model DockerParameter in the database.
Diffs (updated)
-----
src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java c16aa4ccaf021f9da1f02fe2718e6c3a1dc63142
src/main/java/org/apache/aurora/scheduler/storage/db/TaskConfigManager.java 30a258aae69efc5ddb21cdfc06e85d19f0a19cd6
src/main/java/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.java 48f19045885d82e8fb702949b3e64e86e97a6a8b
src/main/resources/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.xml bbd67133ef19255e80d7910bac922020d1b917ba
src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql 52494afbb00e799e58ed9d76de56b70767ed0fda
src/test/java/org/apache/aurora/scheduler/storage/testing/StorageEntityUtil.java 0bde4d8bab3a2ad09e53d024dd5c76b7fcbf3083
Diff: https://reviews.apache.org/r/36735/diff/
Testing
-------
Thanks,
Bill Farner