You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kafka.apache.org by cm...@apache.org on 2023/06/05 23:51:52 UTC

[kafka] 01/02: address review comments

This is an automated email from the ASF dual-hosted git repository.

cmccabe pushed a commit to branch cmccabe_2023-05-10_cleanup
in repository https://gitbox.apache.org/repos/asf/kafka.git

commit 7517dbab6891306deef131b910309fec48a1dc60
Author: Colin P. McCabe <cm...@apache.org>
AuthorDate: Mon Jun 5 16:48:21 2023 -0700

    address review comments
---
 .../java/org/apache/kafka/controller/ReplicationControlManager.java     | 2 +-
 .../test/java/org/apache/kafka/controller/MockAclControlManager.java    | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java b/metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java
index 2dab250cee5..212b12a641a 100644
--- a/metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java
+++ b/metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java
@@ -488,7 +488,7 @@ public class ReplicationControlManager {
 
         if (record.removingReplicas() != null || record.addingReplicas() != null) {
             log.info("Replayed partition assignment change {} for topic {}", record, topicInfo.name);
-        } else if (log.isDebugEnabled()) {
+        } else {
             log.debug("Replayed partition change {} for topic {}", record, topicInfo.name);
         }
     }
diff --git a/metadata/src/test/java/org/apache/kafka/controller/MockAclControlManager.java b/metadata/src/test/java/org/apache/kafka/controller/MockAclControlManager.java
index e14c8e2e4f5..a1cca280f2d 100644
--- a/metadata/src/test/java/org/apache/kafka/controller/MockAclControlManager.java
+++ b/metadata/src/test/java/org/apache/kafka/controller/MockAclControlManager.java
@@ -33,7 +33,7 @@ import java.util.Optional;
 public class MockAclControlManager extends AclControlManager {
     public MockAclControlManager(LogContext logContext,
                                  Optional<ClusterMetadataAuthorizer> authorizer) {
-        super(new LogContext(), new SnapshotRegistry(logContext), authorizer);
+        super(logContext, new SnapshotRegistry(logContext), authorizer);
     }
 
     public List<AclCreateResult> createAndReplayAcls(List<AclBinding> acls) {