You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/06/10 18:23:35 UTC
[GitHub] [incubator-pinot] snleee commented on issue #4289: Cleaning up
getTableName() for segment metadata
snleee commented on issue #4289: Cleaning up getTableName() for segment metadata
URL: https://github.com/apache/incubator-pinot/pull/4289#issuecomment-500534148
> Can you add more descriptions? The only time when you call SegmentMetadata.getTableName() is during segment push?
I have updated the commit message.
1. is required.
2. and 3. is required for backward compatibility (writing table.name to segment zk metadata or segment metadata). We can remove them when we decide to remove `tableName` completely from the segment metadata.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org