You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "Robert Muir (Jira)" <ji...@apache.org> on 2020/10/03 17:54:00 UTC
[jira] [Commented] (LUCENE-9558) Clean up package name conflicts
for analyzers-icu module
[ https://issues.apache.org/jira/browse/LUCENE-9558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17206822#comment-17206822 ]
Robert Muir commented on LUCENE-9558:
-------------------------------------
+1
> Clean up package name conflicts for analyzers-icu module
> --------------------------------------------------------
>
> Key: LUCENE-9558
> URL: https://issues.apache.org/jira/browse/LUCENE-9558
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/analysis
> Reporter: Tomoko Uchida
> Assignee: Tomoko Uchida
> Priority: Minor
>
> analyzers-icu module shares the package names {{o.a.l.collation}} and {{o.a.l.collation.tokenattributes}} with analyzers-common; they need to be renamed.
> There could be two solutions:
> 1. rename "o.a.l.collation" to "o.a.l.a.icu.collation"
> 2. move classes under "o.a.l.collation" to "o.a.l.a.icu" and classes under "o.a.l.collation.tokenattributes" to "o.a.l.a.icu.tokenattributes", and delete "o.a.l.collation" from analyzers-icu
> I would prefer option 2. 1. may complicate the package hierarchy and there already exist {{o.a.l.a.icu.tokenattributes}}. (All classes under "o.a.l.collation" have prefix "ICUCollation", so I think we don't need to keep "collation" in the package name, do we?)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org