You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by GitBox <gi...@apache.org> on 2019/08/23 16:44:47 UTC
[GitHub] [samza] cameronlee314 commented on a change in pull request #1117:
[SAMZA-2283] Samza Sql Diagnostics: make latency metrics changes backward
compatible
cameronlee314 commented on a change in pull request #1117: [SAMZA-2283] Samza Sql Diagnostics: make latency metrics changes backward compatible
URL: https://github.com/apache/samza/pull/1117#discussion_r317214899
##########
File path: samza-api/src/main/java/org/apache/samza/system/IncomingMessageEnvelope.java
##########
@@ -194,7 +216,7 @@ public boolean equals(Object obj) {
@Override
public String toString() {
Review comment:
I wasn't sure about what semantics we wanted. I think there is a reasonable argument either way. But you make a good point that `eventTime` was already not included, so `arrivalTime` can be not included as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services