[Impala-ASF-CR] IMPALA-7504/KUDU-2979 ParseKerberosPrincipal() should use krb5 parse name() instead

["Xiaomeng Zhang (Code Review)" <ge...@cloudera.org>]

Xiaomeng Zhang has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/14433 )

Change subject: IMPALA-7504/KUDU-2979 ParseKerberosPrincipal() should use krb5_parse_name() instead
......................................................................

IMPALA-7504/KUDU-2979 ParseKerberosPrincipal() should use krb5_parse_name() instead

We want to use krb5_parse_name() to parse the principal instead of
creating our own.

As src/kudu/security/init.cc already have g_krb5_ctx initialized,
we want to leverage the code in KUDU, and create a wrap up function
which can be called from IMPALA Krb5parseName(const string& principal,
string* service_name, string* hostname, string* realm)

Test done:
Add an authentication-test to verify principal with special character.
Manually tested with bad format principal, throw out error code 2
instead of original 112 which is BAD_PRINCIPAL_FORMAT error code.

Change-Id: I0e64ebdc10f102dbdc5b87f6fe3f2a0310b1be24
---
M be/src/kudu/security/init.cc
M be/src/kudu/security/init.h
M be/src/rpc/authentication-test.cc
M be/src/util/auth-util.cc
4 files changed, 36 insertions(+), 15 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/33/14433/5
-- 
To view, visit http://gerrit.cloudera.org:8080/14433
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0e64ebdc10f102dbdc5b87f6fe3f2a0310b1be24
Gerrit-Change-Number: 14433
Gerrit-PatchSet: 5
Gerrit-Owner: Xiaomeng Zhang <xi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Xiaomeng Zhang <xi...@cloudera.com>