You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "Wojciech Trocki (JIRA)" <ji...@apache.org> on 2018/05/13 12:15:00 UTC
[jira] [Commented] (CB-13985) Plugin installation fails if the
plugin requires variables on platform add
[ https://issues.apache.org/jira/browse/CB-13985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16473460#comment-16473460 ]
Wojciech Trocki commented on CB-13985:
--------------------------------------
Checking this ticket. It looks like it happens only when spec refers to url, as I could not replicate that using normal versions.
It may be problem with provider here: https://github.com/apache/cordova-lib/blob/ad31610fac93d824ed8fc25761e947fb52894691/src/plugman/variable-merge.js#L47-L52
Going to debug this and provide PR.
> Plugin installation fails if the plugin requires variables on platform add
> --------------------------------------------------------------------------
>
> Key: CB-13985
> URL: https://issues.apache.org/jira/browse/CB-13985
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugman
> Reporter: Benjamin Räder
> Priority: Major
> Labels: bug
>
> If you have a plugin defined in your plugin.xml like this:
> {code:java}
> <plugin name="cordova-plugin-facebook4" spec="git+https://github.com/XXXXXXXXXXXX/cordova-plugin-facebook4.git">
> <variable name="APP_ID" value="1234567890" />
> <variable name="APP_NAME" value="Testapp" />
> </plugin>{code}
> package.json:
> {code:java}
> "cordova-plugin-facebook4": { "APP_ID": "1234567890", "APP_NAME": "Testapp" },
> {code}
> And you try to add a new platform to your project:
> {code:java}
> cordova platform add ios
> {code}
> The plugin cannot be installed because the variables are not passed during the installation phase:
> {code:java}
> Installing "cordova-plugin-facebook4" for ios Failed to install 'cordova-plugin-facebook4': Error: Variable(s) missing: APP_ID, APP_NAME at Object.mergeVariables (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/src/plugman/variable-merge.js:58:15) at /usr/local/lib/node_modules/cordova/node_modules/cordova-lib/src/plugman/install.js:315:44 at _fulfilled (/usr/local/lib/node_modules/cordova/node_modules/q/q.js:787:54) at self.promiseDispatch.done (/usr/local/lib/node_modules/cordova/node_modules/q/q.js:816:30) at Promise.promise.promiseDispatch (/usr/local/lib/node_modules/cordova/node_modules/q/q.js:749:13) at /usr/local/lib/node_modules/cordova/node_modules/q/q.js:557:44 at flush (/usr/local/lib/node_modules/cordova/node_modules/q/q.js:108:17) at process._tickCallback (internal/process/next_tick.js:150:11) Error: Variable(s) missing: APP_ID, APP_NAME
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org