[GitHub] [superset] villebro commented on issue #18747: List which integration tests can easily be converted to unit tests

[GitBox <gi...@apache.org>]

villebro commented on issue #18747:
URL: https://github.com/apache/superset/issues/18747#issuecomment-1041199606


   Thanks for bringing this up @betodealmeida ! I agree this is a really valuable initiative taken on by @ofekisr and will have a great impact on backend test quality going forward. 
   
   For the existing `db_engine_specs` integration tests that require the `self.get_dttm()` fixture, I've created the `dttm` fixture in `tests/unit_tests/common.py` which is used in e.g.`test_mssql.py`.
   
   Converting these are actually a good exercise and a great way to get into the codebase (see #18251 for an example of a db engine spec test migration), so I warmly encourage new backend developers to take a stab at converting a few of these!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org