[jira] [Commented] (COUCHDB-2733) Binary headers cause crashes in CORS

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/COUCHDB-2733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14605560#comment-14605560 ] 

ASF GitHub Bot commented on COUCHDB-2733:
-----------------------------------------

GitHub user iilyak opened a pull request:

    https://github.com/apache/couchdb-chttpd/pull/39

    Account for binary keys fir headers in CORS

    We do have headers' keys represented as either lists or binaries.
    Make sure we don't crash on `string:to_lower`.
    
    COUCHDB-2733

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/iilyak/couchdb-chttpd 2733-binary-cors-headers

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/couchdb-chttpd/pull/39.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #39
    
----
commit 1eed9c5d8a13fc4ea5bd7c06e964f6d7c8e5a1e2
Author: ILYA Khlopotov <ii...@ca.ibm.com>
Date:   2015-06-29T12:45:37Z

    Account for binary keys fir headers in CORS
    
    We do have headers' keys represented as either lists or binaries.
    Make sure we don't crash on `string:to_lower`.
    
    COUCHDB-2733

----


> Binary headers cause crashes in CORS
> ------------------------------------
>
>                 Key: COUCHDB-2733
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-2733
>             Project: CouchDB
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>            Reporter: ILYA
>            Assignee: ILYA
>
> We do have headers' keys represented as either lists or binaries.
> However here https://github.com/apache/couchdb-chttpd/blob/master/src/chttpd_cors.erl#L220 we don't expect binaries.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)