You are viewing a plain text version of this content. The canonical link for it is here.
Posted to codereview@trafodion.apache.org by hegdean <gi...@git.apache.org> on 2015/10/05 21:08:36 UTC

[GitHub] incubator-trafodion pull request: [TRAFODION-1506] TRAFCI on windo...

GitHub user hegdean opened a pull request:

    https://github.com/apache/incubator-trafodion/pull/103

    [TRAFODION-1506] TRAFCI on windows is missing the banner and copyright information

    Fixed the version information for source package
    Fixed other minor issues

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/hegdean/incubator-trafodion wrk-brnch

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-trafodion/pull/103.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #103
    
----
commit 4e2784214bad33882719e766f8b3e5798f3301a1
Author: Anuradha Hegde <an...@esgyn.com>
Date:   2015-10-05T17:32:40Z

    Changed the source package name to contain the version info
    Fixed trafci banner issue for non-unix machines
    Fixed other minor issues

commit b209f13b2eba327fdec3fc974b85afe4506f1438
Author: Anuradha Hegde <an...@esgyn.com>
Date:   2015-10-05T19:05:42Z

    compressed the src package

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: [TRAFODION-1506] TRAFCI on windo...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-trafodion/pull/103


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: [TRAFODION-1506] TRAFCI on windo...

Posted by arvind-narain <gi...@git.apache.org>.
Github user arvind-narain commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/103#discussion_r41202937
  
    --- Diff: core/conn/trafci/utils/trafci.cmd-tmpl ---
    @@ -3,6 +3,8 @@
     CLS
    --- End diff --
    
    Can you add the copyright info in this file ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---