[jira] Updated: (DERBY-903) Remove use of String(byte[]) and String(byte[], int, int) constructors in testing leading to non-portable behaviour

["Myrna van Lunteren (JIRA)" <de...@db.apache.org>]

     [ http://issues.apache.org/jira/browse/DERBY-903?page=all ]

Myrna van Lunteren updated DERBY-903:
-------------------------------------

    Attachment: DERBY-903_021306.stat
                DERBY-903_021306.diff

This patch fixes the occurrence of the constructors as reported, and in addition, fixes the 4 tests to use
fixed strings so the test passes with a different encoding in the following cases:
- string.getBytes()
       especially frequent in the blobclob4BLOB test, where it is used to obtain a number of bytes to insert into a blob. 
       Using this without the encoding causes problems with other encodings.
- change to use FileInputStream and InputStreamReader for subtest clobNegativeTest_Derby265 of blobclob4BLOB. (see also comment in DERBY-575)

> Remove use of String(byte[]) and String(byte[], int, int) constructors in testing leading to non-portable behaviour
> -------------------------------------------------------------------------------------------------------------------
>
>          Key: DERBY-903
>          URL: http://issues.apache.org/jira/browse/DERBY-903
>      Project: Derby
>         Type: Bug
>   Components: Test
>     Versions: 10.2.0.0
>     Reporter: Daniel John Debrunner
>     Assignee: Myrna van Lunteren
>      Fix For: 10.2.0.0
>  Attachments: DERBY-903_021306.diff, DERBY-903_021306.stat
>
> These constructors use the Java default platform encoding to convert the bytes to a String, this typically leads to bugs on platforms with different encodings.
> Replace with code using fixed conversion, or alternative mechanisms. 
> If the call is required its use should be commented as to why it is required.
> org.apache.derbyTesting.functionTests.tests.jdbcapi.blobclob4BLOB
> org.apache.derbyTesting.functionTests.tests.jdbcapi.resultset
> org.apache.derbyTesting.functionTests.tests.lang.coalesceTests
> org.apache.derbyTesting.functionTests.tests.store.streamingColumn
> I generated this list using the Java search in eclipse for references to the constructors
> String(byte[])
> String(byte[],int,int) (no occurrences in java/testing)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira