[GitHub] [incubator-gobblin] sv2000 commented on a change in pull request #2708: [GOBBLIN-852]Reorganize the code for hive registration to isolate function

[GitBox <gi...@apache.org>]

sv2000 commented on a change in pull request #2708: [GOBBLIN-852]Reorganize the code for hive registration to isolate function
URL: https://github.com/apache/incubator-gobblin/pull/2708#discussion_r313123196
 
 

 ##########
 File path: gobblin-core/src/main/java/org/apache/gobblin/publisher/HiveRegistrationPublisher.java
 ##########
 @@ -157,7 +146,9 @@ public void publishData(Collection<? extends WorkUnitState> states) throws IOExc
           if (isPathDedupeEnabled && pathsToRegisterFromSingleState.contains(path)){
             continue;
           }
-          pathsToRegisterFromSingleState.add(path);
+          if(isPathDedupeEnabled) {
 
 Review comment:
   can this if () {} block be merged inside the above if() {} block? e.g. if (isPathDedupeEnabled) { pathsToRegisterFromSingleState.contains(path) ? continue: pathsToRegisterFromSingleState.add(path);}
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services