You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@dolphinscheduler.apache.org by "EricGao888 (via GitHub)" <gi...@apache.org> on 2023/08/07 07:45:30 UTC

[GitHub] [dolphinscheduler] EricGao888 commented on a diff in pull request #14657: [Improvement][helm] configmap changes automatically trigger restart

EricGao888 commented on code in PR #14657:
URL: https://github.com/apache/dolphinscheduler/pull/14657#discussion_r1285501054


##########
deploy/kubernetes/dolphinscheduler/values.yaml:
##########
@@ -141,6 +141,9 @@ security:
         truststorepassword: ""
 
 conf:
+  # auto restart, if true, all components will be restarted automatically after the common configuration is updated. if false, you need to restart the components manually. default is false
+  auto: false

Review Comment:
   Basically I share the same opinions with @Radeity @SbloodyS @qingwli . But I think it is fine if we have a configuration here and set to false by default.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org