You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/06/09 16:11:40 UTC
[GitHub] [hbase-operator-tools] clarax commented on a change in pull request #61: taking one or more files for regions for assigns
clarax commented on a change in pull request #61:
URL: https://github.com/apache/hbase-operator-tools/pull/61#discussion_r436981970
##########
File path: hbase-hbck2/src/main/java/org/apache/hbase/HBCK2.java
##########
@@ -17,6 +17,9 @@
*/
package org.apache.hbase;
+import java.io.BufferedReader;
+import java.io.File;
Review comment:
actual change
##########
File path: hbase-hbck2/src/main/java/org/apache/hbase/HBCK2.java
##########
@@ -269,21 +274,23 @@ int setRegionState(ClusterConnection connection, String region,
}
List<Future<List<String>>> addMissingRegionsInMetaForTables(String...
- nameSpaceOrTable) throws IOException {
+ nameSpaceOrTable) throws IOException {
try (final FsRegionsMetaRecoverer fsRegionsMetaRecoverer =
- new FsRegionsMetaRecoverer(this.conf)) {
+ new FsRegionsMetaRecoverer(this.conf)) {
return fsRegionsMetaRecoverer.addMissingRegionsInMetaForTables(
- formatNameSpaceTableParam(nameSpaceOrTable));
+ formatNameSpaceTableParam(nameSpaceOrTable));
} catch (IOException e) {
LOG.error("Error adding missing regions: ", e);
throw e;
}
}
- List<Long> assigns(Hbck hbck, String [] args) throws IOException {
+ List<Long> assigns(Hbck hbck, String[] args) throws IOException {
Review comment:
Actual changes.
##########
File path: hbase-hbck2/src/main/java/org/apache/hbase/HBCK2.java
##########
@@ -434,23 +463,27 @@ private static void usageAddFsRegionsMissingInMeta(PrintWriter writer) {
writer.println(" namespace, 'tbl_2' in namespace 'n1' and for all tables from");
writer.println(" namespace 'n2':");
writer.println(" $ HBCK2 " + ADD_MISSING_REGIONS_IN_META_FOR_TABLES +
- " default:tbl_1 n1:tbl_2 n2");
+ " default:tbl_1 n1:tbl_2 n2");
writer.println(" Returns HBCK2 an 'assigns' command with all re-inserted regions.");
writer.println(" SEE ALSO: " + REPORT_MISSING_REGIONS_IN_META);
writer.println(" SEE ALSO: " + FIX_META);
}
private static void usageAssigns(PrintWriter writer) {
Review comment:
actual changes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org