You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@sling.apache.org by Radu Cotescu <ra...@apache.org> on 2021/09/21 16:35:53 UTC

[parent pom] missing site distribution management

Hello,

I noticed that commit [0] removed the site distribution management section. Without this the site:stage goal fails for our Maven plugins, with the following error:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-site-plugin:3.9.1:stage (default-cli) on project scriptingbundle-maven-plugin: Missing site information in the distribution management of the project Apache Sling Scripting Bundle Maven Plugin (org.apache.sling:scriptingbundle-maven-plugin:0.4.1-SNAPSHOT)

The referenced project uses version 45 of the parent pom. Should we manually add the distributionManagement section to the Maven plugins? I’ve currently added something like the following in this project:

<distributionManagement>
    <site>
        <id>staging</id>
        <url>file:${project.build.directory}/staging</url>
    </site>
</distributionManagement>
Thanks,
Radu

[0] - https://github.com/apache/sling-parent/commit/a36d73b749732554fc703380e55fbe649219d234

Re: [parent pom] missing site distribution management

Posted by Radu Cotescu <ra...@apache.org>.

Hi Konrad,

No concerns - feel free to merge https://github.com/apache/sling-site/pull/96 <https://github.com/apache/sling-site/pull/96>.

Thanks,
Radu

> On 11 Aug 2022, at 16:36, Konrad Windszus <kw...@apache.org> wrote:
> 
> I also ran into that issue recently and I still think that the site goal is enough (no need for stage, https://maven.apache.org/plugins/maven-site-plugin/stage-mojo.html).
> 
> Every URL we would put into the distributionManagement site URL of the parent would just be a guess and could be wrong.
> 
> Any concerns before removing the "site:stage" goal from step 2 in https://sling.apache.org/documentation/development/release-management.html#appendix-b-deploy-maven-plugin-documentation-if-applicable?
> 
> Thanks,
> Konrad
> 
> On 2021/09/21 18:12:27 Radu Cotescu wrote:
>> Hi Konrad,
>> 
>>> On 21 Sep 2021, at 19:35, Konrad Windszus <ko...@gmx.de> wrote:
>>> 
>>> Hi Radu,
>>> I never use the site goals "deploy" or "stage" for Sling modules. Instead of the former we have a rather manual process outlined in https://sling.apache.org/documentation/development/release-management.html#appendix-b-deploy-maven-plugin-documentation-if-applicable. The latter is only useful to test links between module sites in a multi module build. I don't think we have that use case in Sling.
>>> 
>>> The distributionManagement url I removed from parent was invalid and IMHO never used.
>> 
>> Yes, I don’t dispute that. 
>> 
>>> Any reason why a simple "mvn clean site" does not suffice to test the Maven site?
>>> 
>> 
>> That should work. The only question is why did we recommend to copy the staged version to the folder where we publish the documentation for the Maven plugins. In my case the site and staging folders have the exact same content. If that’s always the case, then we should update our release management docs.
>> 
>> Thanks,
>> Radu
>> 
>>

Re: [parent pom] missing site distribution management

Posted by Konrad Windszus <kw...@apache.org>.

I also ran into that issue recently and I still think that the site goal is enough (no need for stage, https://maven.apache.org/plugins/maven-site-plugin/stage-mojo.html).

Every URL we would put into the distributionManagement site URL of the parent would just be a guess and could be wrong.

Any concerns before removing the "site:stage" goal from step 2 in https://sling.apache.org/documentation/development/release-management.html#appendix-b-deploy-maven-plugin-documentation-if-applicable?

Thanks,
Konrad

On 2021/09/21 18:12:27 Radu Cotescu wrote:
> Hi Konrad,
> 
> > On 21 Sep 2021, at 19:35, Konrad Windszus <ko...@gmx.de> wrote:
> > 
> > Hi Radu,
> > I never use the site goals "deploy" or "stage" for Sling modules. Instead of the former we have a rather manual process outlined in https://sling.apache.org/documentation/development/release-management.html#appendix-b-deploy-maven-plugin-documentation-if-applicable. The latter is only useful to test links between module sites in a multi module build. I don't think we have that use case in Sling.
> > 
> > The distributionManagement url I removed from parent was invalid and IMHO never used.
> 
> Yes, I don’t dispute that. 
> 
> > Any reason why a simple "mvn clean site" does not suffice to test the Maven site?
> > 
> 
> That should work. The only question is why did we recommend to copy the staged version to the folder where we publish the documentation for the Maven plugins. In my case the site and staging folders have the exact same content. If that’s always the case, then we should update our release management docs.
> 
> Thanks,
> Radu
> 
>

Re: [parent pom] missing site distribution management

Posted by Radu Cotescu <ra...@apache.org>.

Hi Konrad,

> On 21 Sep 2021, at 19:35, Konrad Windszus <ko...@gmx.de> wrote:
> 
> Hi Radu,
> I never use the site goals "deploy" or "stage" for Sling modules. Instead of the former we have a rather manual process outlined in https://sling.apache.org/documentation/development/release-management.html#appendix-b-deploy-maven-plugin-documentation-if-applicable. The latter is only useful to test links between module sites in a multi module build. I don't think we have that use case in Sling.
> 
> The distributionManagement url I removed from parent was invalid and IMHO never used.

Yes, I don’t dispute that. 

> Any reason why a simple "mvn clean site" does not suffice to test the Maven site?
> 

That should work. The only question is why did we recommend to copy the staged version to the folder where we publish the documentation for the Maven plugins. In my case the site and staging folders have the exact same content. If that’s always the case, then we should update our release management docs.

Thanks,
Radu

Re: [parent pom] missing site distribution management

Posted by Konrad Windszus <ko...@gmx.de>.

Hi Radu,
I never use the site goals "deploy" or "stage" for Sling modules. Instead of the former we have a rather manual process outlined in https://sling.apache.org/documentation/development/release-management.html#appendix-b-deploy-maven-plugin-documentation-if-applicable. The latter is only useful to test links between module sites in a multi module build. I don't think we have that use case in Sling.

The distributionManagement url I removed from parent was invalid and IMHO never used.
Any reason why a simple "mvn clean site" does not suffice to test the Maven site?

Konrad

> On 21. Sep 2021, at 18:35, Radu Cotescu <ra...@apache.org> wrote:
> 
> Hello,
> 
> I noticed that commit [0] removed the site distribution management section. Without this the site:stage goal fails for our Maven plugins, with the following error:
> 
> [ERROR] Failed to execute goal org.apache.maven.plugins:maven-site-plugin:3.9.1:stage (default-cli) on project scriptingbundle-maven-plugin: Missing site information in the distribution management of the project Apache Sling Scripting Bundle Maven Plugin (org.apache.sling:scriptingbundle-maven-plugin:0.4.1-SNAPSHOT)
> 
> The referenced project uses version 45 of the parent pom. Should we manually add the distributionManagement section to the Maven plugins? I’ve currently added something like the following in this project:
> 
> <distributionManagement>
>    <site>
>        <id>staging</id>
>        <url>file:${project.build.directory}/staging</url>
>    </site>
> </distributionManagement>
> Thanks,
> Radu
> 
> [0] - https://github.com/apache/sling-parent/commit/a36d73b749732554fc703380e55fbe649219d234