You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by GitBox <gi...@apache.org> on 2022/12/21 06:49:20 UTC
[GitHub] [incubator-celeborn] FMX opened a new pull request, #1104: [CELEBORN-157] Change prefix of configurations to celeborn.
FMX opened a new pull request, #1104:
URL: https://github.com/apache/incubator-celeborn/pull/1104
[CELEBORN-157] Change prefix of configurations to celeborn.
### What changes were proposed in this pull request?
### Why are the changes needed?
### Does this PR introduce _any_ user-facing change?
### How was this patch tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] codecov[bot] commented on pull request #1104: [CELEBORN-157] Change prefix of configurations to celeborn.
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #1104:
URL: https://github.com/apache/incubator-celeborn/pull/1104#issuecomment-1360932192
# [Codecov](https://codecov.io/gh/apache/incubator-celeborn/pull/1104?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1104](https://codecov.io/gh/apache/incubator-celeborn/pull/1104?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b89751d) into [main](https://codecov.io/gh/apache/incubator-celeborn/commit/f13dfb7421c6fe1ba4a8edd7ab08c70c73f5c441?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f13dfb7) will **increase** coverage by `0.03%`.
> The diff coverage is `50.00%`.
```diff
@@ Coverage Diff @@
## main #1104 +/- ##
============================================
+ Coverage 25.17% 25.20% +0.03%
Complexity 781 781
============================================
Files 215 215
Lines 18270 18278 +8
Branches 2032 2032
============================================
+ Hits 4598 4605 +7
- Misses 13361 13362 +1
Partials 311 311
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-celeborn/pull/1104?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ache/celeborn/common/util/ShutdownHookManager.java](https://codecov.io/gh/apache/incubator-celeborn/pull/1104/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9jb21tb24vdXRpbC9TaHV0ZG93bkhvb2tNYW5hZ2VyLmphdmE=) | `0.00% <ø> (ø)` | |
| [.../celeborn/common/internal/config/ConfigEntry.scala](https://codecov.io/gh/apache/incubator-celeborn/pull/1104/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvY2VsZWJvcm4vY29tbW9uL2ludGVybmFsL2NvbmZpZy9Db25maWdFbnRyeS5zY2FsYQ==) | `77.99% <ø> (ø)` | |
| [...apache/celeborn/common/metrics/MetricsConfig.scala](https://codecov.io/gh/apache/incubator-celeborn/pull/1104/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvY2VsZWJvcm4vY29tbW9uL21ldHJpY3MvTWV0cmljc0NvbmZpZy5zY2FsYQ==) | `0.00% <0.00%> (ø)` | |
| [.../apache/celeborn/common/rpc/netty/Dispatcher.scala](https://codecov.io/gh/apache/incubator-celeborn/pull/1104/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvY2VsZWJvcm4vY29tbW9uL3JwYy9uZXR0eS9EaXNwYXRjaGVyLnNjYWxh) | `0.00% <0.00%> (ø)` | |
| [...apache/celeborn/common/rpc/netty/NettyRpcEnv.scala](https://codecov.io/gh/apache/incubator-celeborn/pull/1104/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvY2VsZWJvcm4vY29tbW9uL3JwYy9uZXR0eS9OZXR0eVJwY0Vudi5zY2FsYQ==) | `0.00% <0.00%> (ø)` | |
| [.../celeborn/service/deploy/worker/FetchHandler.scala](https://codecov.io/gh/apache/incubator-celeborn/pull/1104/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d29ya2VyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvY2VsZWJvcm4vc2VydmljZS9kZXBsb3kvd29ya2VyL0ZldGNoSGFuZGxlci5zY2FsYQ==) | `39.82% <0.00%> (ø)` | |
| [...cala/org/apache/celeborn/common/CelebornConf.scala](https://codecov.io/gh/apache/incubator-celeborn/pull/1104/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvY2VsZWJvcm4vY29tbW9uL0NlbGVib3JuQ29uZi5zY2FsYQ==) | `80.55% <87.50%> (+0.08%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] FMX merged pull request #1104: [CELEBORN-157] Change prefix of configurations to celeborn.
Posted by GitBox <gi...@apache.org>.
FMX merged PR #1104:
URL: https://github.com/apache/incubator-celeborn/pull/1104
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] waitinfuture commented on pull request #1104: [CELEBORN-157] Change prefix of configurations to celeborn.
Posted by GitBox <gi...@apache.org>.
waitinfuture commented on PR #1104:
URL: https://github.com/apache/incubator-celeborn/pull/1104#issuecomment-1362305471
Seems this patch causes RetryCommitFilesTest to fail
```
Job aborted due to stage failure: Task 1 in stage 0.0 failed 1 times, most recent failure: Lost task 1.0 in stage 0.0 (TID 1) (192.168.2.105 executor driver): java.io.IOException: Register shuffle failed for shuffle local-1671674878465-0
at org.apache.celeborn.client.ShuffleClientImpl.pushOrMergeData(ShuffleClientImpl.java:522)
at org.apache.celeborn.client.ShuffleClientImpl.pushData(ShuffleClientImpl.java:816)
at org.apache.celeborn.client.write.DataPusher.pushData(DataPusher.java:173)
at org.apache.celeborn.client.write.DataPusher.access$700(DataPusher.java:32)
at org.apache.celeborn.client.write.DataPusher$1.run(DataPusher.java:117)
```
Plz take a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org