[dbcp] PooledConnectionImpl.prepareStatement(String, int, int)

[Todd Carmichael <to...@concur.com>]

DBCP Team,
What is the reason that the extended version of prepareStatement in
PooledConnectionImpl that accepts resultSetType and resultSetConcurrency
does not pass those values down to the the real connection object?  I will
pass those values to the connection object IF statement pooling is enabled.
However, if statement pooling is not enabled it does not pass those values:

~ line 257
PreparedStatement prepareStatement(String sql, int resultSetType, int
resultSetConcurrency) throws SQLException {
        if (pstmtPool == null) {
            return connection.prepareStatement(sql);


Thanks.
ToddC

Re: [dbcp] PooledConnectionImpl.prepareStatement(String, int, int)

[Dirk Verbeeck <di...@pandora.be>]

Looks like a typical copy/paste error.
Please make a bugzilla issue for it.

-- Dirk

Todd Carmichael wrote:
> DBCP Team,
> What is the reason that the extended version of prepareStatement in
> PooledConnectionImpl that accepts resultSetType and resultSetConcurrency
> does not pass those values down to the the real connection object?  I will
> pass those values to the connection object IF statement pooling is enabled.
> However, if statement pooling is not enabled it does not pass those values:
> 
> ~ line 257
> PreparedStatement prepareStatement(String sql, int resultSetType, int
> resultSetConcurrency) throws SQLException {
>         if (pstmtPool == null) {
>             return connection.prepareStatement(sql);
> 
> 
> Thanks.
> ToddC
> 



---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org