You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@thrift.apache.org by "kpumuk (via GitHub)" <gi...@apache.org> on 2026/07/24 01:28:33 UTC

[PR] THRIFT-6120: Bound Ruby TLS accept handshakes [thrift]

kpumuk opened a new pull request, #3669:
URL: https://github.com/apache/thrift/pull/3669

   <!-- Explain the changes in the pull request below: -->
     
   `SSLServerSocket` previously applied its client timeout only after OpenSSL had completed the TLS handshake. A TCP peer that remained silent or stopped partway through negotiation could therefore keep `accept` blocked beyond the configured timeout.
   
   This changes the accept path to accept the TCP connection first and drive TLS negotiation nonblockingly against one monotonic deadline. If that deadline expires, the accepted connection is closed and the existing TLS error boundary is preserved, allowing the server accept loop to recover. Successful connections continue to be returned as `Thrift::Socket` instances with the configured client timeout.
   
   <!-- We recommend you review the checklist/tips before submitting a pull request. -->
   
   - [x] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? [THRIFT-6120](https://issues.apache.org/jira/browse/THRIFT-6120)
   - [x] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
   - [x] Did you squash your changes to a single commit?  (not required, but preferred)
   - [x] Did you do your best to avoid breaking changes?  If one was needed, did you label the Jira ticket with "Breaking-Change"?
   - [ ] If your change does not involve any code, include `[skip ci]` anywhere in the commit message to free up build resources.
   
   <!--
     The Contributing Guide at:
     https://github.com/apache/thrift/blob/master/CONTRIBUTING.md
     has more details and tips for committing properly.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] THRIFT-6120: Bound Ruby TLS accept handshakes [thrift]

Posted by "kpumuk (via GitHub)" <gi...@apache.org>.
kpumuk merged PR #3669:
URL: https://github.com/apache/thrift/pull/3669


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] THRIFT-6120: Bound Ruby TLS accept handshakes [thrift]

Posted by "kpumuk (via GitHub)" <gi...@apache.org>.
kpumuk commented on PR #3669:
URL: https://github.com/apache/thrift/pull/3669#issuecomment-5081712195

   Copilot, you are not helping.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org