[GitHub] [incubator-yunikorn-k8shim] wilfred-s commented on pull request #371: [YUNIKORN-1076] Robust handling of invalid Task Group annotation

[GitBox <gi...@apache.org>]

wilfred-s commented on pull request #371:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/371#issuecomment-1047355027


   I am happy with the event added.
   
   @yuchaoran2011 & @HuangTing-Yao:
   However when I look at the original jira [YUNIKORN-1076](https://issues.apache.org/jira/browse/YUNIKORN-1076) the request was to look at rejecting the pod. The point that we pull out all this task group detail from the pod is part of the `addPod()` processing in the manager. We cannot reject the pod at that point as we do not have an application yet. The `addPod()` will create a new application. At the moment that even happens if the parsing fails. Having the application is again not enough. The application state machine does not allow rejecting an application in the new state. It must be submitted first and then the core can reject it. There is no internal way to reject the application. We can also not return the parse failure from `getAppMetadata()` as that would cause it to be interpreted as a task which could have all kinds of side effects.
   
   If we are happy with just the event on the pod we can leave it at this. 
   I do think that we need to look at this in more detail, however that will end up being a much larger and way more complex change.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org