You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2013/08/01 01:15:24 UTC

Review Request 13173: Revert flag environment variable semantics.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13173/
-----------------------------------------------------------

Review request for mesos and Vinod Kone.


Repository: mesos-git


Description
-------

An environment variable will no longer be considered an "unknown" flag.


Diffs
-----

  3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 77d36e6ff44da3ceb940954b801bc7e8308482d5 
  src/local/local.cpp 3364c15f6b2374d752e83eb8a1c3c49de6bcc259 
  src/sched/sched.cpp 62abd38447ad32ccc64e542d42b7d45f62816714 

Diff: https://reviews.apache.org/r/13173/diff/


Testing
-------

make check


Thanks,

Benjamin Hindman

Re: Review Request 13173: Revert flag environment variable semantics.

Posted by Vinod Kone <vi...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13173/#review24389
-----------------------------------------------------------

Ship it!


Ship It!

- Vinod Kone


On July 31, 2013, 11:15 p.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13173/
> -----------------------------------------------------------
> 
> (Updated July 31, 2013, 11:15 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> An environment variable will no longer be considered an "unknown" flag.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 77d36e6ff44da3ceb940954b801bc7e8308482d5 
>   src/local/local.cpp 3364c15f6b2374d752e83eb8a1c3c49de6bcc259 
>   src/sched/sched.cpp 62abd38447ad32ccc64e542d42b7d45f62816714 
> 
> Diff: https://reviews.apache.org/r/13173/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>