You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gilbert Song <so...@gmail.com> on 2016/02/02 18:18:19 UTC
Re: Review Request 43021: Implemented docker runtime isolator
interface.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43021/
-----------------------------------------------------------
(Updated Feb. 2, 2016, 9:18 a.m.)
Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
Bugs: MESOS-4517
https://issues.apache.org/jira/browse/MESOS-4517
Repository: mesos
Description
-------
Implemented docker runtime isolator interface.
Diffs
-----
src/CMakeLists.txt 6b2c7cbffa57d44b913419ad68fc66eaeca169d0
src/Makefile.am fac17f4bac3b2ddda0384dec8b0ed6f960bd24d1
src/slave/containerizer/mesos/isolators/docker/runtime.hpp PRE-CREATION
src/slave/containerizer/mesos/isolators/docker/runtime.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/43021/diff/
Testing
-------
make check (ubuntu14.04 + clang-3.6)
Thanks,
Gilbert Song
Re: Review Request 43021: Implemented docker runtime isolator
interface.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43021/#review117439
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Feb. 2, 2016, 5:18 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43021/
> -----------------------------------------------------------
>
> (Updated Feb. 2, 2016, 5:18 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
>
>
> Bugs: MESOS-4517
> https://issues.apache.org/jira/browse/MESOS-4517
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Implemented docker runtime isolator interface.
>
>
> Diffs
> -----
>
> src/CMakeLists.txt 6b2c7cbffa57d44b913419ad68fc66eaeca169d0
> src/Makefile.am fac17f4bac3b2ddda0384dec8b0ed6f960bd24d1
> src/slave/containerizer/mesos/isolators/docker/runtime.hpp PRE-CREATION
> src/slave/containerizer/mesos/isolators/docker/runtime.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/43021/diff/
>
>
> Testing
> -------
>
> make check (ubuntu14.04 + clang-3.6)
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 43021: Implemented docker runtime isolator
interface.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43021/
-----------------------------------------------------------
(Updated Feb. 3, 2016, 12:41 p.m.)
Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
Bugs: MESOS-4517
https://issues.apache.org/jira/browse/MESOS-4517
Repository: mesos
Description
-------
Implemented docker runtime isolator interface.
Diffs (updated)
-----
src/CMakeLists.txt 6b2c7cbffa57d44b913419ad68fc66eaeca169d0
src/Makefile.am fac17f4bac3b2ddda0384dec8b0ed6f960bd24d1
src/slave/containerizer/mesos/isolators/docker/runtime.hpp PRE-CREATION
src/slave/containerizer/mesos/isolators/docker/runtime.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/43021/diff/
Testing
-------
make check (ubuntu14.04 + clang-3.6)
Thanks,
Gilbert Song
Re: Review Request 43021: Implemented docker runtime isolator
interface.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43021/#review117438
-----------------------------------------------------------
src/slave/containerizer/mesos/isolators/docker/runtime.hpp (line 26)
<https://reviews.apache.org/r/43021/#comment178620>
s/Isolator/isolator/
src/slave/containerizer/mesos/isolators/docker/runtime.cpp (line 23)
<https://reviews.apache.org/r/43021/#comment178621>
We try to avoid using this now. Let's use 'using process::XXX' explicitly here.
- Jie Yu
On Feb. 2, 2016, 5:18 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43021/
> -----------------------------------------------------------
>
> (Updated Feb. 2, 2016, 5:18 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
>
>
> Bugs: MESOS-4517
> https://issues.apache.org/jira/browse/MESOS-4517
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Implemented docker runtime isolator interface.
>
>
> Diffs
> -----
>
> src/CMakeLists.txt 6b2c7cbffa57d44b913419ad68fc66eaeca169d0
> src/Makefile.am fac17f4bac3b2ddda0384dec8b0ed6f960bd24d1
> src/slave/containerizer/mesos/isolators/docker/runtime.hpp PRE-CREATION
> src/slave/containerizer/mesos/isolators/docker/runtime.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/43021/diff/
>
>
> Testing
> -------
>
> make check (ubuntu14.04 + clang-3.6)
>
>
> Thanks,
>
> Gilbert Song
>
>