[jira] [Created] (SHIRO-562) WildcardPermission calls String.trim() twice in setParts()

["Matt Bishop (JIRA)" <ji...@apache.org>]

Matt Bishop created SHIRO-562:
---------------------------------

             Summary: WildcardPermission calls String.trim() twice in setParts()
                 Key: SHIRO-562
                 URL: https://issues.apache.org/jira/browse/SHIRO-562
             Project: Shiro
          Issue Type: Improvement
          Components: Authorization (access control) 
    Affects Versions: 1.2.4
         Environment: any
            Reporter: Matt Bishop
            Priority: Trivial


WildcardPermission.setParts does this: 
{quote}
 if (wildcardString == null || wildcardString.trim().length() == 0) {
            throw new IllegalArgumentException("Wildcard string cannot be null or empty. Make sure permission strings are properly formatted.");
        }

        wildcardString = wildcardString.trim();
{quote}

Given the frequency of the use of this method it would be better to capture the first trim().



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)