You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by tae-jun <gi...@git.apache.org> on 2016/11/14 18:01:38 UTC
[GitHub] zeppelin pull request #1630: [ZEPPELIN-1629] Enable renaming folder from the...
GitHub user tae-jun opened a pull request:
https://github.com/apache/zeppelin/pull/1630
[ZEPPELIN-1629] Enable renaming folder from the main page
### What is this PR for?
This PR will enable renaming folder from the main page.
I wrote some codes. Hope this PR is the start of folder-based features. (e.g folder authorization, folder focused view)
Please check when you have some time!
Thanks \U0001f604
### What type of PR is it?
[Feature]
### What is the Jira issue?
[ZEPPELIN-1629](https://issues.apache.org/jira/browse/ZEPPELIN-1629)
### How should this be tested?
Change folder names!
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tae-jun/zeppelin ZEPPELIN-1629
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1630.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1630
----
commit 2ceda58a4d37caadb17c444790642d217c4827de
Author: Jun <i2...@gmail.com>
Date: 2016-11-14T17:50:26Z
add renaming folder from the main page
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1630: [ZEPPELIN-1629] Enable renaming folder from the main p...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1630
@tae-jun Great work! Take your time and feel free to ping me again when you're ready.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1630: [ZEPPELIN-1629] Enable renaming folder from the main p...
Posted by tae-jun <gi...@git.apache.org>.
Github user tae-jun commented on the issue:
https://github.com/apache/zeppelin/pull/1630
@AhyoungRyu Fixed what you mentioned :) Always thanks for the review \U0001f604
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1630: [ZEPPELIN-1629] Enable renaming folder from the main p...
Posted by tae-jun <gi...@git.apache.org>.
Github user tae-jun commented on the issue:
https://github.com/apache/zeppelin/pull/1630
@AhyoungRyu Thanks! I also think `notebook` is a little bit weird :) I merged your PR thanks.
This change will affect other insufficient privileges error messages as well:
* Insufficient privileges to `read` ~~notebook~~
* Insufficient privileges to `update` ~~notebook~~
* Insufficient privileges to `remove` ~~notebook~~
* Insufficient privileges to `write` ~~notebook~~
* Insufficient privileges to `clear output` ~~notebook~~
I prefer removing `notebook`. What do you think guys? If anyone has a concern about this, please tell.
And about CI, I suffered from that error when I tried to compile only one project (e.g. `zeppelin-server`). Since `zeppelin-server` depends on `zeppelin-interpreter` and `zeppelin-zengine`, I had to build two dependencies and `install` them on local maven repo, which can be done with `mvn clean package install -DskipTests`. If not, when it tries to compile `zeppelin-server`, it cannot find symbols of `zeppelin-zengine` and goes to fail.
However, I'm not sure that CI only recompiles changed files. I will look into it, and tell you if I get some more information.
(CI was green before \U0001f62d)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1630: [ZEPPELIN-1629] Enable renaming folder from the...
Posted by tae-jun <gi...@git.apache.org>.
GitHub user tae-jun reopened a pull request:
https://github.com/apache/zeppelin/pull/1630
[ZEPPELIN-1629] Enable renaming folder from the main page
### What is this PR for?
This PR will enable renaming folder from the main page.
I wrote some codes. Hope this PR is the start of folder-based features. (e.g folder authorization, folder focused view)
Please check when you have some time!
Thanks \U0001f604
### What type of PR is it?
[Feature]
### Todos
* [x] - Fix ConcurrentModificationException of FolderView
### What is the Jira issue?
[ZEPPELIN-1629](https://issues.apache.org/jira/browse/ZEPPELIN-1629)
### How should this be tested?
Change folder names!
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tae-jun/zeppelin ZEPPELIN-1629
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1630.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1630
----
commit ca4e1603dc1ced8e20135dc6db113cde64f3fb30
Author: Jun <i2...@gmail.com>
Date: 2016-11-14T17:50:26Z
add renaming folder from the main page
commit e7e41c4a865ef129abc9367c5dc157a2686ad29c
Author: Jun <i2...@gmail.com>
Date: 2016-11-15T12:16:33Z
Fix ConcurrentModificationException of FolderView, and add more comments
commit 4a3d722883f5869f3cb867bd19f4a48ff4aeb561
Author: Jun <i2...@gmail.com>
Date: 2016-11-19T09:20:14Z
Fix awkward insufficient privileges error message
commit cb0ec4f6e48fdb0a5ab2f72da4c033dc06f84d85
Author: Jun <i2...@gmail.com>
Date: 2016-11-19T09:29:40Z
Make permission error message more natural
commit e5cd77072922348a5f104eb675214ca5b61802ea
Author: Jun <i2...@gmail.com>
Date: 2016-11-19T09:37:16Z
Include note name in permission error message
commit 7f7e6bd30dc78367cc7cc7b59fa89390bc890e48
Author: AhyoungRyu <fb...@hanmail.net>
Date: 2016-11-20T09:26:29Z
Change notebook -> note
commit 90182a6910d29cba15e1b82f86016737c1e71aa3
Author: Jun <i2...@gmail.com>
Date: 2016-11-20T11:05:21Z
Install Zeppelin to local maven repo after building
commit 11b95eb24cc0e79c564ce4cfd8e0837c823d748b
Author: Jun <i2...@gmail.com>
Date: 2016-11-20T11:33:42Z
Revert "Install Zeppelin to local maven repo after building"
This reverts commit 3ad2a2db9d202673068fe3d8b1c1bf5364fe01aa.
commit 757bb10576149f769d37ec37ef46c9b41f4ef22c
Author: Jun Kim <i2...@gmail.com>
Date: 2016-11-20T18:04:01Z
Address @AhyoungRyu's suggestions
commit 2f55d05c0db20c0bc2f438fddee0851f4893260f
Author: Jun <i2...@gmail.com>
Date: 2016-11-23T16:39:07Z
Fix cannot find symbol error
commit ad84c4c8dd48fdbc741ea8664a615dd055b84bdc
Author: Jun <i2...@gmail.com>
Date: 2016-11-24T10:48:22Z
Revert "Fix cannot find symbol error"
This reverts commit 2f55d05c0db20c0bc2f438fddee0851f4893260f.
commit 30ccea9c939953f41379178f73d1291c00d8d415
Author: Jun <i2...@gmail.com>
Date: 2016-11-24T10:52:02Z
Fix \u201ccannot find symbol\u201d error by importing `Folder`
commit 0f729b71854fb74dcfc9b7f4f32b2fcece6dbc86
Author: Jun <i2...@gmail.com>
Date: 2016-11-24T11:14:16Z
Fix error that not working when a note\u2019s name changed
commit 01e6bc91238a49a5c66b018638db43d2763eb5a1
Author: Jun Kim <i2...@gmail.com>
Date: 2016-11-28T17:29:04Z
Fix the error @AhyoungRyu addressed and add more test cases
commit 27fe1eacf7bb1710a834c814bf4c89fab63e5615
Author: Jun Kim <i2...@gmail.com>
Date: 2016-11-29T11:22:44Z
Fix the folder test error
commit b719d635dba505e8c2aa7b10a2e577fa967e1805
Author: Jun Kim <i2...@gmail.com>
Date: 2016-11-30T10:41:30Z
Fix concurrent modification error
commit af71eddde6ca66491d13eaa92688f3f7b08e9229
Author: Jun Kim <i2...@gmail.com>
Date: 2016-11-30T11:29:35Z
Add warning sign if a renamed folder will be merged
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1630: [ZEPPELIN-1629] Enable renaming folder from the...
Posted by tae-jun <gi...@git.apache.org>.
GitHub user tae-jun reopened a pull request:
https://github.com/apache/zeppelin/pull/1630
[ZEPPELIN-1629] Enable renaming folder from the main page
### What is this PR for?
This PR will enable renaming folder from the main page.
I wrote some codes. Hope this PR is the start of folder-based features. (e.g folder authorization, folder focused view)
Please check when you have some time!
Thanks \U0001f604
### What type of PR is it?
[Feature]
### Todos
* [x] - Fix ConcurrentModificationException of FolderView
### What is the Jira issue?
[ZEPPELIN-1629](https://issues.apache.org/jira/browse/ZEPPELIN-1629)
### How should this be tested?
Change folder names!
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tae-jun/zeppelin ZEPPELIN-1629
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1630.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1630
----
commit ca4e1603dc1ced8e20135dc6db113cde64f3fb30
Author: Jun <i2...@gmail.com>
Date: 2016-11-14T17:50:26Z
add renaming folder from the main page
commit e7e41c4a865ef129abc9367c5dc157a2686ad29c
Author: Jun <i2...@gmail.com>
Date: 2016-11-15T12:16:33Z
Fix ConcurrentModificationException of FolderView, and add more comments
commit 4a3d722883f5869f3cb867bd19f4a48ff4aeb561
Author: Jun <i2...@gmail.com>
Date: 2016-11-19T09:20:14Z
Fix awkward insufficient privileges error message
commit cb0ec4f6e48fdb0a5ab2f72da4c033dc06f84d85
Author: Jun <i2...@gmail.com>
Date: 2016-11-19T09:29:40Z
Make permission error message more natural
commit e5cd77072922348a5f104eb675214ca5b61802ea
Author: Jun <i2...@gmail.com>
Date: 2016-11-19T09:37:16Z
Include note name in permission error message
commit 7f7e6bd30dc78367cc7cc7b59fa89390bc890e48
Author: AhyoungRyu <fb...@hanmail.net>
Date: 2016-11-20T09:26:29Z
Change notebook -> note
commit 90182a6910d29cba15e1b82f86016737c1e71aa3
Author: Jun <i2...@gmail.com>
Date: 2016-11-20T11:05:21Z
Install Zeppelin to local maven repo after building
commit 11b95eb24cc0e79c564ce4cfd8e0837c823d748b
Author: Jun <i2...@gmail.com>
Date: 2016-11-20T11:33:42Z
Revert "Install Zeppelin to local maven repo after building"
This reverts commit 3ad2a2db9d202673068fe3d8b1c1bf5364fe01aa.
commit 757bb10576149f769d37ec37ef46c9b41f4ef22c
Author: Jun Kim <i2...@gmail.com>
Date: 2016-11-20T18:04:01Z
Address @AhyoungRyu's suggestions
commit 2f55d05c0db20c0bc2f438fddee0851f4893260f
Author: Jun <i2...@gmail.com>
Date: 2016-11-23T16:39:07Z
Fix cannot find symbol error
commit ad84c4c8dd48fdbc741ea8664a615dd055b84bdc
Author: Jun <i2...@gmail.com>
Date: 2016-11-24T10:48:22Z
Revert "Fix cannot find symbol error"
This reverts commit 2f55d05c0db20c0bc2f438fddee0851f4893260f.
commit 30ccea9c939953f41379178f73d1291c00d8d415
Author: Jun <i2...@gmail.com>
Date: 2016-11-24T10:52:02Z
Fix \u201ccannot find symbol\u201d error by importing `Folder`
commit 0f729b71854fb74dcfc9b7f4f32b2fcece6dbc86
Author: Jun <i2...@gmail.com>
Date: 2016-11-24T11:14:16Z
Fix error that not working when a note\u2019s name changed
commit 01e6bc91238a49a5c66b018638db43d2763eb5a1
Author: Jun Kim <i2...@gmail.com>
Date: 2016-11-28T17:29:04Z
Fix the error @AhyoungRyu addressed and add more test cases
commit 27fe1eacf7bb1710a834c814bf4c89fab63e5615
Author: Jun Kim <i2...@gmail.com>
Date: 2016-11-29T11:22:44Z
Fix the folder test error
commit b719d635dba505e8c2aa7b10a2e577fa967e1805
Author: Jun Kim <i2...@gmail.com>
Date: 2016-11-30T10:41:30Z
Fix concurrent modification error
commit af71eddde6ca66491d13eaa92688f3f7b08e9229
Author: Jun Kim <i2...@gmail.com>
Date: 2016-11-30T11:29:35Z
Add warning sign if a renamed folder will be merged
commit 5dee99c5149927819f01022a77a0574713b87a2b
Author: Jun Kim <i2...@gmail.com>
Date: 2016-11-30T16:01:49Z
Check permission of every notes under the folder which is target of renaming
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1630: [ZEPPELIN-1629] Enable renaming folder from the main p...
Posted by tae-jun <gi...@git.apache.org>.
Github user tae-jun commented on the issue:
https://github.com/apache/zeppelin/pull/1630
@AhyoungRyu Yeah!!! Finally!!!
CI is green!!! It was my fault! I didn't import `Folder` at `zeppelin-server`.
(Why was it green before...?)
Please take a look!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1630: [ZEPPELIN-1629] Enable renaming folder from the main p...
Posted by tae-jun <gi...@git.apache.org>.
Github user tae-jun commented on the issue:
https://github.com/apache/zeppelin/pull/1630
@AhyoungRyu Yeah! CI is green \U0001f604 Please review! Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1630: [ZEPPELIN-1629] Enable renaming folder from the main p...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1630
@tae-jun Sorry for my late response.
I tested but can't edit the dir name in root dir level. The folder name can be modified only in below level. Please see the below attached gif img.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1630: [ZEPPELIN-1629] Enable renaming folder from the...
Posted by tae-jun <gi...@git.apache.org>.
GitHub user tae-jun reopened a pull request:
https://github.com/apache/zeppelin/pull/1630
[ZEPPELIN-1629] Enable renaming folder from the main page
### What is this PR for?
This PR will enable renaming folder from the main page.
I wrote some codes. Hope this PR is the start of folder-based features. (e.g folder authorization, folder focused view)
Please check when you have some time!
Thanks \U0001f604
### What type of PR is it?
[Feature]
### Todos
* [x] - Fix ConcurrentModificationException of FolderView
### What is the Jira issue?
[ZEPPELIN-1629](https://issues.apache.org/jira/browse/ZEPPELIN-1629)
### How should this be tested?
Change folder names!
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tae-jun/zeppelin ZEPPELIN-1629
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1630.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1630
----
commit ca4e1603dc1ced8e20135dc6db113cde64f3fb30
Author: Jun <i2...@gmail.com>
Date: 2016-11-14T17:50:26Z
add renaming folder from the main page
commit e7e41c4a865ef129abc9367c5dc157a2686ad29c
Author: Jun <i2...@gmail.com>
Date: 2016-11-15T12:16:33Z
Fix ConcurrentModificationException of FolderView, and add more comments
commit 4a3d722883f5869f3cb867bd19f4a48ff4aeb561
Author: Jun <i2...@gmail.com>
Date: 2016-11-19T09:20:14Z
Fix awkward insufficient privileges error message
commit cb0ec4f6e48fdb0a5ab2f72da4c033dc06f84d85
Author: Jun <i2...@gmail.com>
Date: 2016-11-19T09:29:40Z
Make permission error message more natural
commit e5cd77072922348a5f104eb675214ca5b61802ea
Author: Jun <i2...@gmail.com>
Date: 2016-11-19T09:37:16Z
Include note name in permission error message
commit 7f7e6bd30dc78367cc7cc7b59fa89390bc890e48
Author: AhyoungRyu <fb...@hanmail.net>
Date: 2016-11-20T09:26:29Z
Change notebook -> note
commit 90182a6910d29cba15e1b82f86016737c1e71aa3
Author: Jun <i2...@gmail.com>
Date: 2016-11-20T11:05:21Z
Install Zeppelin to local maven repo after building
commit 11b95eb24cc0e79c564ce4cfd8e0837c823d748b
Author: Jun <i2...@gmail.com>
Date: 2016-11-20T11:33:42Z
Revert "Install Zeppelin to local maven repo after building"
This reverts commit 3ad2a2db9d202673068fe3d8b1c1bf5364fe01aa.
commit 757bb10576149f769d37ec37ef46c9b41f4ef22c
Author: Jun Kim <i2...@gmail.com>
Date: 2016-11-20T18:04:01Z
Address @AhyoungRyu's suggestions
commit 2f55d05c0db20c0bc2f438fddee0851f4893260f
Author: Jun <i2...@gmail.com>
Date: 2016-11-23T16:39:07Z
Fix cannot find symbol error
commit ad84c4c8dd48fdbc741ea8664a615dd055b84bdc
Author: Jun <i2...@gmail.com>
Date: 2016-11-24T10:48:22Z
Revert "Fix cannot find symbol error"
This reverts commit 2f55d05c0db20c0bc2f438fddee0851f4893260f.
commit 30ccea9c939953f41379178f73d1291c00d8d415
Author: Jun <i2...@gmail.com>
Date: 2016-11-24T10:52:02Z
Fix \u201ccannot find symbol\u201d error by importing `Folder`
commit 0f729b71854fb74dcfc9b7f4f32b2fcece6dbc86
Author: Jun <i2...@gmail.com>
Date: 2016-11-24T11:14:16Z
Fix error that not working when a note\u2019s name changed
commit 01e6bc91238a49a5c66b018638db43d2763eb5a1
Author: Jun Kim <i2...@gmail.com>
Date: 2016-11-28T17:29:04Z
Fix the error @AhyoungRyu addressed and add more test cases
commit 27fe1eacf7bb1710a834c814bf4c89fab63e5615
Author: Jun Kim <i2...@gmail.com>
Date: 2016-11-29T11:22:44Z
Fix the folder test error
commit b719d635dba505e8c2aa7b10a2e577fa967e1805
Author: Jun Kim <i2...@gmail.com>
Date: 2016-11-30T10:41:30Z
Fix concurrent modification error
commit af71eddde6ca66491d13eaa92688f3f7b08e9229
Author: Jun Kim <i2...@gmail.com>
Date: 2016-11-30T11:29:35Z
Add warning sign if a renamed folder will be merged
commit 5dee99c5149927819f01022a77a0574713b87a2b
Author: Jun Kim <i2...@gmail.com>
Date: 2016-11-30T16:01:49Z
Check permission of every notes under the folder which is target of renaming
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1630: [ZEPPELIN-1629] Enable renaming folder from the main p...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1630
Tested and working really nicely. Looks awesome to me!
Thanks @tae-jun for the great contribution!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1630: [ZEPPELIN-1629] Enable renaming folder from the...
Posted by tae-jun <gi...@git.apache.org>.
Github user tae-jun closed the pull request at:
https://github.com/apache/zeppelin/pull/1630
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1630: [ZEPPELIN-1629] Enable renaming folder from the main p...
Posted by tae-jun <gi...@git.apache.org>.
Github user tae-jun commented on the issue:
https://github.com/apache/zeppelin/pull/1630
@AhyoungRyu I fixed what you mentioned \U0001f604 Please review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1630: [ZEPPELIN-1629] Enable renaming folder from the main p...
Posted by tae-jun <gi...@git.apache.org>.
Github user tae-jun commented on the issue:
https://github.com/apache/zeppelin/pull/1630
I've tested more and it was fine most times. But occasionally it doesn't work well. I think it should be tested more! I don't know why for now but I will figure it out and ping when it's ready :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1630: [ZEPPELIN-1629] Enable renaming folder from the main p...
Posted by tae-jun <gi...@git.apache.org>.
Github user tae-jun commented on the issue:
https://github.com/apache/zeppelin/pull/1630
@AhyoungRyu Thanks for your kind review. I appreciate it.
Actually, I didn't test with Shiro ^^; and didn't know what `op` parameter means. So thanks very much.
I changed `renameFolder` to `rename folder of` you addressed and also `renameNote` to `rename`.
Now it looks like this:
<img width="441" alt="2016-11-19 6 37 26" src="https://cloud.githubusercontent.com/assets/8201019/20454545/462de7b8-ae87-11e6-9dea-89a355e7cf30.png">
<img width="276" alt="2016-11-19 6 31 21" src="https://cloud.githubusercontent.com/assets/8201019/20454517/77115a1e-ae86-11e6-9284-baf39b3c5498.png">
I also included note name which needs permission \U0001f604
What do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1630: [ZEPPELIN-1629] Enable renaming folder from the main p...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1630
Tested and it's working nicely! LGTM \U0001f44d
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1630: [ZEPPELIN-1629] Enable renaming folder from the main p...
Posted by tae-jun <gi...@git.apache.org>.
Github user tae-jun commented on the issue:
https://github.com/apache/zeppelin/pull/1630
CI failure is because of me. I will fix it :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1630: [ZEPPELIN-1629] Enable renaming folder from the main p...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1630
Great work @tae-jun. LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1630: [ZEPPELIN-1629] Enable renaming folder from the main p...
Posted by tae-jun <gi...@git.apache.org>.
Github user tae-jun commented on the issue:
https://github.com/apache/zeppelin/pull/1630
@soralee Hi! I added the feature you suggested. What do you think? Is title or content of warning message appropriate? Thanks for the cool suggestion!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1630: [ZEPPELIN-1629] Enable renaming folder from the main p...
Posted by tae-jun <gi...@git.apache.org>.
Github user tae-jun commented on the issue:
https://github.com/apache/zeppelin/pull/1630
@AhyoungRyu @soralee Yeah! CI is green!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1630: [ZEPPELIN-1629] Enable renaming folder from the main p...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1630
Merge to master if there're no more comments
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1630: [ZEPPELIN-1629] Enable renaming folder from the main p...
Posted by tae-jun <gi...@git.apache.org>.
Github user tae-jun commented on the issue:
https://github.com/apache/zeppelin/pull/1630
I found out bugs by adding loggers and fixed them!
CI is green and it seems to work perfectly. I think it's good to go now \U0001f604
Please when you have some time. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1630: [ZEPPELIN-1629] Enable renaming folder from the main p...
Posted by tae-jun <gi...@git.apache.org>.
Github user tae-jun commented on the issue:
https://github.com/apache/zeppelin/pull/1630
Fixed error and CI is green!
Ready for review! \U0001f604
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1630: [ZEPPELIN-1629] Enable renaming folder from the...
Posted by tae-jun <gi...@git.apache.org>.
GitHub user tae-jun reopened a pull request:
https://github.com/apache/zeppelin/pull/1630
[ZEPPELIN-1629] Enable renaming folder from the main page
### What is this PR for?
This PR will enable renaming folder from the main page.
I wrote some codes. Hope this PR is the start of folder-based features. (e.g folder authorization, folder focused view)
Please check when you have some time!
Thanks \U0001f604
### What type of PR is it?
[Feature]
### Todos
* [x] - Fix ConcurrentModificationException of FolderView
### What is the Jira issue?
[ZEPPELIN-1629](https://issues.apache.org/jira/browse/ZEPPELIN-1629)
### How should this be tested?
Change folder names!
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tae-jun/zeppelin ZEPPELIN-1629
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1630.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1630
----
commit 2ceda58a4d37caadb17c444790642d217c4827de
Author: Jun <i2...@gmail.com>
Date: 2016-11-14T17:50:26Z
add renaming folder from the main page
commit a24e8a9cdb250e2216bb99298a8451418d4299df
Author: Jun <i2...@gmail.com>
Date: 2016-11-15T12:16:33Z
Fix ConcurrentModificationException of FolderView, and add more comments
commit 85d30d70caadb39805325ac0ea5b50c40ec08829
Author: Jun <i2...@gmail.com>
Date: 2016-11-19T09:20:14Z
Fix awkward insufficient privileges error message
commit 4a9771e70f32f2a9a41c0627198c5416314ec83b
Author: Jun <i2...@gmail.com>
Date: 2016-11-19T09:29:40Z
Make permission error message more natural
commit 24f968388d9194a26a6a2aa88cf5bdbff18eaf80
Author: Jun <i2...@gmail.com>
Date: 2016-11-19T09:37:16Z
Include note name in permission error message
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1630: [ZEPPELIN-1629] Enable renaming folder from the main p...
Posted by tae-jun <gi...@git.apache.org>.
Github user tae-jun commented on the issue:
https://github.com/apache/zeppelin/pull/1630
@AhyoungRyu Thanks for review \U0001f604 Don't need to hurry! I will check and ping you :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1630: [ZEPPELIN-1629] Enable renaming folder from the...
Posted by tae-jun <gi...@git.apache.org>.
Github user tae-jun closed the pull request at:
https://github.com/apache/zeppelin/pull/1630
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1630: [ZEPPELIN-1629] Enable renaming folder from the...
Posted by tae-jun <gi...@git.apache.org>.
GitHub user tae-jun reopened a pull request:
https://github.com/apache/zeppelin/pull/1630
[ZEPPELIN-1629] Enable renaming folder from the main page
### What is this PR for?
This PR will enable renaming folder from the main page.
I wrote some codes. Hope this PR is the start of folder-based features. (e.g folder authorization, folder focused view)
Please check when you have some time!
Thanks \U0001f604
### What type of PR is it?
[Feature]
### Todos
* [x] - Fix ConcurrentModificationException of FolderView
### What is the Jira issue?
[ZEPPELIN-1629](https://issues.apache.org/jira/browse/ZEPPELIN-1629)
### How should this be tested?
Change folder names!
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tae-jun/zeppelin ZEPPELIN-1629
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1630.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1630
----
commit ca4e1603dc1ced8e20135dc6db113cde64f3fb30
Author: Jun <i2...@gmail.com>
Date: 2016-11-14T17:50:26Z
add renaming folder from the main page
commit e7e41c4a865ef129abc9367c5dc157a2686ad29c
Author: Jun <i2...@gmail.com>
Date: 2016-11-15T12:16:33Z
Fix ConcurrentModificationException of FolderView, and add more comments
commit 4a3d722883f5869f3cb867bd19f4a48ff4aeb561
Author: Jun <i2...@gmail.com>
Date: 2016-11-19T09:20:14Z
Fix awkward insufficient privileges error message
commit cb0ec4f6e48fdb0a5ab2f72da4c033dc06f84d85
Author: Jun <i2...@gmail.com>
Date: 2016-11-19T09:29:40Z
Make permission error message more natural
commit e5cd77072922348a5f104eb675214ca5b61802ea
Author: Jun <i2...@gmail.com>
Date: 2016-11-19T09:37:16Z
Include note name in permission error message
commit 7f7e6bd30dc78367cc7cc7b59fa89390bc890e48
Author: AhyoungRyu <fb...@hanmail.net>
Date: 2016-11-20T09:26:29Z
Change notebook -> note
commit 90182a6910d29cba15e1b82f86016737c1e71aa3
Author: Jun <i2...@gmail.com>
Date: 2016-11-20T11:05:21Z
Install Zeppelin to local maven repo after building
commit 11b95eb24cc0e79c564ce4cfd8e0837c823d748b
Author: Jun <i2...@gmail.com>
Date: 2016-11-20T11:33:42Z
Revert "Install Zeppelin to local maven repo after building"
This reverts commit 3ad2a2db9d202673068fe3d8b1c1bf5364fe01aa.
commit 757bb10576149f769d37ec37ef46c9b41f4ef22c
Author: Jun Kim <i2...@gmail.com>
Date: 2016-11-20T18:04:01Z
Address @AhyoungRyu's suggestions
commit 2f55d05c0db20c0bc2f438fddee0851f4893260f
Author: Jun <i2...@gmail.com>
Date: 2016-11-23T16:39:07Z
Fix cannot find symbol error
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1630: [ZEPPELIN-1629] Enable renaming folder from the...
Posted by tae-jun <gi...@git.apache.org>.
Github user tae-jun closed the pull request at:
https://github.com/apache/zeppelin/pull/1630
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1630: [ZEPPELIN-1629] Enable renaming folder from the main p...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1630
@soralee What a nice suggestion! @tae-jun I think it's cool!!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1630: [ZEPPELIN-1629] Enable renaming folder from the main p...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1630
@tae-jun It works well when I tried to rename folder name. And I think It's good idea to let user know which notes that he don't have permission exactly. Thanks :)
But currently CI is failed with below compilation error. Could you take a look again?
```
[ERROR] COMPILATION ERROR :
[INFO] -------------------------------------------------------------
[ERROR] /home/travis/build/apache/zeppelin/zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java:[774,5] cannot find symbol
symbol: class Folder
location: class org.apache.zeppelin.socket.NotebookServer
[INFO] 1 error
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1630: [ZEPPELIN-1629] Enable renaming folder from the main p...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1630
@tae-jun Thanks for your prompt update. Appreciated your continues work. Tested again and checked the root folder naming issue is gone now. But when I create **over 3 depth** folder structure, then the root folder name can't be modified again. Here are the reproducing steps.
1. Create note with `/a/b/c`
2. Try to edit root folder `a` with `d` -> click `Rename` btn
3. It's not changed to `d`. Still remained as `a`
Could you check again? We're almost done I think!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1630: [ZEPPELIN-1629] Enable renaming folder from the main p...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1630
Awesome. Let me test this. Will ping you again :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1630: [ZEPPELIN-1629] Enable renaming folder from the main p...
Posted by soralee <gi...@git.apache.org>.
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/1630
@tae-jun It is very AWESOME \U0001f44d and thanks you for the accept my suggestion.
Let me check again after CI is green \U0001f604
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1630: [ZEPPELIN-1629] Enable renaming folder from the...
Posted by tae-jun <gi...@git.apache.org>.
Github user tae-jun closed the pull request at:
https://github.com/apache/zeppelin/pull/1630
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1630: [ZEPPELIN-1629] Enable renaming folder from the main p...
Posted by tae-jun <gi...@git.apache.org>.
Github user tae-jun commented on the issue:
https://github.com/apache/zeppelin/pull/1630
I guess CI fails because it only recompiles changed files. (since build time is too short)
It should be about 30min.
Is there any way to compile the whole project again? I ran CI on [my own repository](https://travis-ci.org/tae-jun/zeppelin). It failed on some profiles because of Ignite interpreter. (what is relevance between Ignite interpreter and my PR? \U0001f62d) But it passed on other profiles whereas every profile failed on this repository.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1630: [ZEPPELIN-1629] Enable renaming folder from the...
Posted by tae-jun <gi...@git.apache.org>.
Github user tae-jun closed the pull request at:
https://github.com/apache/zeppelin/pull/1630
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1630: [ZEPPELIN-1629] Enable renaming folder from the main p...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1630
@tae-jun And one more thing, it would be better to keep consistency between `Note` and `Notebook`(combination of several notes). I pushed one commit to your branch, could you please take a look https://github.com/tae-jun/zeppelin/pull/1?
It will be shown when user rename the folder(I removed `notebook`):
<img width="595" alt="screen shot 2016-11-20 at 10 25 22 am" src="https://cloud.githubusercontent.com/assets/10060731/20461892/d857a00e-af0c-11e6-92de-095215062fdd.png">
And then user rename the note:
<img width="599" alt="screen shot 2016-11-20 at 10 25 05 am" src="https://cloud.githubusercontent.com/assets/10060731/20461895/efdaa4b0-af0c-11e6-904c-667f6bcc82cc.png">
And also when user create a note, I changed `Example: NoteDir1/Notebook1` -> `NoteDir1/Note1`
<img width="596" alt="screen shot 2016-11-20 at 10 24 01 am" src="https://cloud.githubusercontent.com/assets/10060731/20461899/04f7cd78-af0d-11e6-97a8-825b1fec1932.png">
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1630: [ZEPPELIN-1629] Enable renaming folder from the main p...
Posted by tae-jun <gi...@git.apache.org>.
Github user tae-jun commented on the issue:
https://github.com/apache/zeppelin/pull/1630
@AhyoungRyu Always thanks for the review \U0001f604
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1630: [ZEPPELIN-1629] Enable renaming folder from the...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1630
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1630: [ZEPPELIN-1629] Enable renaming folder from the main p...
Posted by soralee <gi...@git.apache.org>.
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/1630
@tae-jun This is Cool! and It works well!
So, I suggest one thing. I think it would be nice to appear popup which is whether user will merge the folders or not before merging folders. In my case, It is familiar to me :)
What do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1630: [ZEPPELIN-1629] Enable renaming folder from the...
Posted by tae-jun <gi...@git.apache.org>.
GitHub user tae-jun reopened a pull request:
https://github.com/apache/zeppelin/pull/1630
[ZEPPELIN-1629] Enable renaming folder from the main page
### What is this PR for?
This PR will enable renaming folder from the main page.
I wrote some codes. Hope this PR is the start of folder-based features. (e.g folder authorization, folder focused view)
Please check when you have some time!
Thanks \U0001f604
### What type of PR is it?
[Feature]
### Todos
* [x] - Fix ConcurrentModificationException of FolderView
### What is the Jira issue?
[ZEPPELIN-1629](https://issues.apache.org/jira/browse/ZEPPELIN-1629)
### How should this be tested?
Change folder names!
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tae-jun/zeppelin ZEPPELIN-1629
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1630.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1630
----
commit ca4e1603dc1ced8e20135dc6db113cde64f3fb30
Author: Jun <i2...@gmail.com>
Date: 2016-11-14T17:50:26Z
add renaming folder from the main page
commit e7e41c4a865ef129abc9367c5dc157a2686ad29c
Author: Jun <i2...@gmail.com>
Date: 2016-11-15T12:16:33Z
Fix ConcurrentModificationException of FolderView, and add more comments
commit 4a3d722883f5869f3cb867bd19f4a48ff4aeb561
Author: Jun <i2...@gmail.com>
Date: 2016-11-19T09:20:14Z
Fix awkward insufficient privileges error message
commit cb0ec4f6e48fdb0a5ab2f72da4c033dc06f84d85
Author: Jun <i2...@gmail.com>
Date: 2016-11-19T09:29:40Z
Make permission error message more natural
commit e5cd77072922348a5f104eb675214ca5b61802ea
Author: Jun <i2...@gmail.com>
Date: 2016-11-19T09:37:16Z
Include note name in permission error message
commit 7f7e6bd30dc78367cc7cc7b59fa89390bc890e48
Author: AhyoungRyu <fb...@hanmail.net>
Date: 2016-11-20T09:26:29Z
Change notebook -> note
commit 90182a6910d29cba15e1b82f86016737c1e71aa3
Author: Jun <i2...@gmail.com>
Date: 2016-11-20T11:05:21Z
Install Zeppelin to local maven repo after building
commit 11b95eb24cc0e79c564ce4cfd8e0837c823d748b
Author: Jun <i2...@gmail.com>
Date: 2016-11-20T11:33:42Z
Revert "Install Zeppelin to local maven repo after building"
This reverts commit 3ad2a2db9d202673068fe3d8b1c1bf5364fe01aa.
commit 757bb10576149f769d37ec37ef46c9b41f4ef22c
Author: Jun Kim <i2...@gmail.com>
Date: 2016-11-20T18:04:01Z
Address @AhyoungRyu's suggestions
commit 2f55d05c0db20c0bc2f438fddee0851f4893260f
Author: Jun <i2...@gmail.com>
Date: 2016-11-23T16:39:07Z
Fix cannot find symbol error
commit ad84c4c8dd48fdbc741ea8664a615dd055b84bdc
Author: Jun <i2...@gmail.com>
Date: 2016-11-24T10:48:22Z
Revert "Fix cannot find symbol error"
This reverts commit 2f55d05c0db20c0bc2f438fddee0851f4893260f.
commit 30ccea9c939953f41379178f73d1291c00d8d415
Author: Jun <i2...@gmail.com>
Date: 2016-11-24T10:52:02Z
Fix \u201ccannot find symbol\u201d error by importing `Folder`
commit 0f729b71854fb74dcfc9b7f4f32b2fcece6dbc86
Author: Jun <i2...@gmail.com>
Date: 2016-11-24T11:14:16Z
Fix error that not working when a note\u2019s name changed
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1630: [ZEPPELIN-1629] Enable renaming folder from the main p...
Posted by tae-jun <gi...@git.apache.org>.
Github user tae-jun commented on the issue:
https://github.com/apache/zeppelin/pull/1630
@AhyoungRyu Sorry for my late response! But it's due to tests :)
I reproduced the error you mentioned and you were right!
Furthermore, chasing a reason of the error, I notice that there are more possibilities of error. So I wrote more codes and added more test cases.
## Folder merging test
## Renaming a high depth folder test
I thought this new feature is simple to implement... but now I don't think so...^^; I tested a lot of times, but maybe there are more bugs. So please test this when you have some time.
Thanks \U0001f604
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1630: [ZEPPELIN-1629] Enable renaming folder from the main p...
Posted by tae-jun <gi...@git.apache.org>.
Github user tae-jun commented on the issue:
https://github.com/apache/zeppelin/pull/1630
Thanks @Leemoonsoo! I appreciate your review \U0001f604
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1630: [ZEPPELIN-1629] Enable renaming folder from the main p...
Posted by tae-jun <gi...@git.apache.org>.
Github user tae-jun commented on the issue:
https://github.com/apache/zeppelin/pull/1630
@soralee Thanks for the review! \U0001f604 That's a great idea! I will give some effect on the front-end and ping you again. Thanks :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1630: [ZEPPELIN-1629] Enable renaming folder from the...
Posted by tae-jun <gi...@git.apache.org>.
Github user tae-jun closed the pull request at:
https://github.com/apache/zeppelin/pull/1630
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1630: [ZEPPELIN-1629] Enable renaming folder from the main p...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1630
@tae-jun Build it again and tested, but It works well as you intended. It was my bad.
I tested two cases: \w & \wt Shiro. Both are works well.
Probably it's a nitpick,
<img width="592" alt="screen shot 2016-11-18 at 7 00 52 pm" src="https://cloud.githubusercontent.com/assets/10060731/20440848/06789188-adc2-11e6-89cd-7ce9c2c20cb7.png">
when I try to rename the folder name at home screen, the above msg is shown up. Could you change `renameFolder Notebook` to `rename folder`? (I know `renameFolder` comes from `op` and `notebook` is hardcoded, but sounds a bit awkward \u315c_\u315c)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1630: [ZEPPELIN-1629] Enable renaming folder from the main p...
Posted by tae-jun <gi...@git.apache.org>.
Github user tae-jun commented on the issue:
https://github.com/apache/zeppelin/pull/1630
@AhyoungRyu ping ping~ I tested!
But it just works fine with me. I tested both running ZeppelinServer from IntelliJ and binary built from `mvn clean package -DskipTests`
I use macOS 10.12.1 and Chrome. Could you please share your test environment? \U0001f604
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---