[GitHub] [logging-log4j2] Dretch commented on pull request #585: LOG4J2-3170 Make EncodingPatternConverter CRLF/HTML encoding run in O(n) time, worst-case, rather than O(n ^ 2)

[GitBox <gi...@apache.org>]

Dretch commented on pull request #585:
URL: https://github.com/apache/logging-log4j2/pull/585#issuecomment-933250517


   Thanks @vy , I had not tried the combination of JDK 8 and JDK 11 before.
   
   However, this still has the issue with `sun.reflect.Reflection` not being there:
   
   My `~/.m2/toolchains.xml`:
   ``` xml
   <?xml version="1.0" encoding="UTF8"?>
   <toolchains>
     <toolchain>
       <type>jdk</type>
       <provides>
         <version>8</version>
         <vendor>sun</vendor>
       </provides>
       <configuration>
         <jdkHome>/Users/garethsmith/.sdkman/candidates/java/8.0.292.j9-adpt</jdkHome>
       </configuration>
     </toolchain>
     <toolchain>
       <type>jdk</type>
       <provides>
         <version>11</version>
         <vendor>sun</vendor>
       </provides>
       <configuration>
         <jdkHome>/Users/garethsmith/.sdkman/candidates/java/11.0.6.hs-adpt</jdkHome>
       </configuration>
     </toolchain>
   </toolchains>
   ```
   
   `mvn clean install` error message:
   ```
   [INFO] ------------------------------------------------------------------------
   [INFO] BUILD FAILURE
   [INFO] ------------------------------------------------------------------------
   [INFO] Total time:  18.275 s
   [INFO] Finished at: 2021-10-04T09:04:03+01:00
   [INFO] ------------------------------------------------------------------------
   [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:testCompile (default-testCompile) on project log4j-api: Compilation failure
   [ERROR] /Users/garethsmith/projects/github-apache/logging-log4j2/log4j-api/src/test/java/org/apache/logging/log4j/util/StackLocatorUtilTest.java:[25,18] error: cannot find symbol
   [ERROR]   symbol:   class Reflection
   [ERROR]   location: package sun.reflect
   [ERROR] 
   [ERROR] -> [Help 1]
   [ERROR] 
   [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
   [ERROR] Re-run Maven using the -X switch to enable full debug logging.
   [ERROR] 
   [ERROR] For more information about the errors and possible solutions, please read the following articles:
   [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
   [ERROR] 
   [ERROR] After correcting the problems, you can resume the build with the command
   [ERROR]   mvn <args> -rf :log4j-api
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org