[GitHub] [datasketches-cpp] jbapple commented on a diff in pull request #324: Remove write-only variables

[GitBox <gi...@apache.org>]

jbapple commented on code in PR #324:
URL: https://github.com/apache/datasketches-cpp/pull/324#discussion_r1064779030


##########
sampling/include/var_opt_sketch_impl.hpp:
##########
@@ -752,18 +752,16 @@ string<A> var_opt_sketch<T, A>::items_to_string(bool print_gap) const {
   std::ostringstream os;
   os << "### Sketch Items" << std::endl;
   const uint32_t array_length = (n_ < k_ ? n_ : k_ + 1);
-  for (uint32_t i = 0, display_idx = 0; i < array_length; ++i) {

Review Comment:
   Both places or just one?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org