You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wink.apache.org by "Mike Rheinheimer (JIRA)" <ji...@apache.org> on 2009/10/09 18:57:31 UTC
[jira] Created: (WINK-216) tolerate empty path segments to support
empty PathParams
tolerate empty path segments to support empty PathParams
--------------------------------------------------------
Key: WINK-216
URL: https://issues.apache.org/jira/browse/WINK-216
Project: Wink
Issue Type: Improvement
Components: Common
Reporter: Mike Rheinheimer
This is a followup to WINK-214.
Not sure how exactly we want to approach this. There is a message on the user list requesting support for:
@Path("/testRuns/{testRunsParams}/testSuites/{testSuitesParams}")
http://localhost:8080/testqueryapi/rest/testRuns/;name=jaro/testSuites/;eyes=blue
The problem is that no PathParam was specified in the designated locations; we only have matrix params, so these segments are empty when the URI is normalized in UriTemplateNormalizer.normalize.
input --> /testRuns//testSuites/
output --> /testRuns/testSuites/
The double slash is correctly converted to single slash. To support this request, we would have to do something special to allow the empty path segment to not be normalized. See attached test patch (which goes on top of WINK-214 patch).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WINK-216) tolerate empty path segments to support
empty PathParams
Posted by "Bryant Luk (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryant Luk resolved WINK-216.
-----------------------------
Assignee: Bryant Luk
Fix Version/s: 1.1
Resolution: Fixed
The scenario described should be fixed now in SVN revision 935254 by forcing the URI normalization earlier.
> tolerate empty path segments to support empty PathParams
> --------------------------------------------------------
>
> Key: WINK-216
> URL: https://issues.apache.org/jira/browse/WINK-216
> Project: Wink
> Issue Type: Improvement
> Components: Common
> Reporter: Mike Rheinheimer
> Assignee: Bryant Luk
> Fix For: 1.1
>
> Attachments: WINK_216.patch
>
>
> This is a followup to WINK-214.
> Not sure how exactly we want to approach this. There is a message on the user list requesting support for:
> @Path("/testRuns/{testRunsParams}/testSuites/{testSuitesParams}")
> http://localhost:8080/testqueryapi/rest/testRuns/;name=jaro/testSuites/;eyes=blue
> The problem is that no PathParam was specified in the designated locations; we only have matrix params, so these segments are empty when the URI is normalized in UriTemplateProcessor.normalizeUri.
> input --> /testRuns//testSuites/
> output --> /testRuns/testSuites/
> The double slash is correctly converted to single slash. To support this request, we would have to do something special to allow the empty path segment to not be normalized. See attached test patch (which goes on top of WINK-214 patch).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (WINK-216) tolerate empty path segments to support
empty PathParams
Posted by "Mike Rheinheimer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mike Rheinheimer closed WINK-216.
---------------------------------
> tolerate empty path segments to support empty PathParams
> --------------------------------------------------------
>
> Key: WINK-216
> URL: https://issues.apache.org/jira/browse/WINK-216
> Project: Wink
> Issue Type: Improvement
> Components: Common
> Reporter: Mike Rheinheimer
> Assignee: Bryant Luk
> Fix For: 1.1
>
> Attachments: WINK_216.patch
>
>
> This is a followup to WINK-214.
> Not sure how exactly we want to approach this. There is a message on the user list requesting support for:
> @Path("/testRuns/{testRunsParams}/testSuites/{testSuitesParams}")
> http://localhost:8080/testqueryapi/rest/testRuns/;name=jaro/testSuites/;eyes=blue
> The problem is that no PathParam was specified in the designated locations; we only have matrix params, so these segments are empty when the URI is normalized in UriTemplateProcessor.normalizeUri.
> input --> /testRuns//testSuites/
> output --> /testRuns/testSuites/
> The double slash is correctly converted to single slash. To support this request, we would have to do something special to allow the empty path segment to not be normalized. See attached test patch (which goes on top of WINK-214 patch).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WINK-216) tolerate empty path segments to support
empty PathParams
Posted by "Mike Rheinheimer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mike Rheinheimer updated WINK-216:
----------------------------------
Attachment: WINK_216.patch
> tolerate empty path segments to support empty PathParams
> --------------------------------------------------------
>
> Key: WINK-216
> URL: https://issues.apache.org/jira/browse/WINK-216
> Project: Wink
> Issue Type: Improvement
> Components: Common
> Reporter: Mike Rheinheimer
> Attachments: WINK_216.patch
>
>
> This is a followup to WINK-214.
> Not sure how exactly we want to approach this. There is a message on the user list requesting support for:
> @Path("/testRuns/{testRunsParams}/testSuites/{testSuitesParams}")
> http://localhost:8080/testqueryapi/rest/testRuns/;name=jaro/testSuites/;eyes=blue
> The problem is that no PathParam was specified in the designated locations; we only have matrix params, so these segments are empty when the URI is normalized in UriTemplateProcessor.normalizeUri.
> input --> /testRuns//testSuites/
> output --> /testRuns/testSuites/
> The double slash is correctly converted to single slash. To support this request, we would have to do something special to allow the empty path segment to not be normalized. See attached test patch (which goes on top of WINK-214 patch).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WINK-216) tolerate empty path segments to
support empty PathParams
Posted by "Mike Rheinheimer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12764097#action_12764097 ]
Mike Rheinheimer commented on WINK-216:
---------------------------------------
For reference, the email in the user list is: http://mail-archives.apache.org/mod_mbox/incubator-wink-user/200910.mbox/%3C54E8BE02CCDA404A8D6FB4538A32DA905E59676347@GVW1120EXC.americas.hpqcorp.net%3E
> tolerate empty path segments to support empty PathParams
> --------------------------------------------------------
>
> Key: WINK-216
> URL: https://issues.apache.org/jira/browse/WINK-216
> Project: Wink
> Issue Type: Improvement
> Components: Common
> Reporter: Mike Rheinheimer
> Attachments: WINK_216.patch
>
>
> This is a followup to WINK-214.
> Not sure how exactly we want to approach this. There is a message on the user list requesting support for:
> @Path("/testRuns/{testRunsParams}/testSuites/{testSuitesParams}")
> http://localhost:8080/testqueryapi/rest/testRuns/;name=jaro/testSuites/;eyes=blue
> The problem is that no PathParam was specified in the designated locations; we only have matrix params, so these segments are empty when the URI is normalized in UriTemplateProcessor.normalizeUri.
> input --> /testRuns//testSuites/
> output --> /testRuns/testSuites/
> The double slash is correctly converted to single slash. To support this request, we would have to do something special to allow the empty path segment to not be normalized. See attached test patch (which goes on top of WINK-214 patch).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WINK-216) tolerate empty path segments to
support empty PathParams
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12858225#action_12858225 ]
Hudson commented on WINK-216:
-----------------------------
Integrated in Wink-Trunk-JDK1.5 #311 (See [http://hudson.zones.apache.org/hudson/job/Wink-Trunk-JDK1.5/311/])
Update UriTemplateProcessor encoding
Remove the need to do multiple passes
of UriHelper.normalizeUri() since an
initial pass is made in UriInfoImpl#
buildRequestPath which is called
per request.
This should also fix [WINK-216].
> tolerate empty path segments to support empty PathParams
> --------------------------------------------------------
>
> Key: WINK-216
> URL: https://issues.apache.org/jira/browse/WINK-216
> Project: Wink
> Issue Type: Improvement
> Components: Common
> Reporter: Mike Rheinheimer
> Assignee: Bryant Luk
> Fix For: 1.1
>
> Attachments: WINK_216.patch
>
>
> This is a followup to WINK-214.
> Not sure how exactly we want to approach this. There is a message on the user list requesting support for:
> @Path("/testRuns/{testRunsParams}/testSuites/{testSuitesParams}")
> http://localhost:8080/testqueryapi/rest/testRuns/;name=jaro/testSuites/;eyes=blue
> The problem is that no PathParam was specified in the designated locations; we only have matrix params, so these segments are empty when the URI is normalized in UriTemplateProcessor.normalizeUri.
> input --> /testRuns//testSuites/
> output --> /testRuns/testSuites/
> The double slash is correctly converted to single slash. To support this request, we would have to do something special to allow the empty path segment to not be normalized. See attached test patch (which goes on top of WINK-214 patch).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (WINK-216) tolerate empty path segments to support
empty PathParams
Posted by "Mike Rheinheimer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mike Rheinheimer updated WINK-216:
----------------------------------
Description:
This is a followup to WINK-214.
Not sure how exactly we want to approach this. There is a message on the user list requesting support for:
@Path("/testRuns/{testRunsParams}/testSuites/{testSuitesParams}")
http://localhost:8080/testqueryapi/rest/testRuns/;name=jaro/testSuites/;eyes=blue
The problem is that no PathParam was specified in the designated locations; we only have matrix params, so these segments are empty when the URI is normalized in UriTemplateProcessor.normalizeUri.
input --> /testRuns//testSuites/
output --> /testRuns/testSuites/
The double slash is correctly converted to single slash. To support this request, we would have to do something special to allow the empty path segment to not be normalized. See attached test patch (which goes on top of WINK-214 patch).
was:
This is a followup to WINK-214.
Not sure how exactly we want to approach this. There is a message on the user list requesting support for:
@Path("/testRuns/{testRunsParams}/testSuites/{testSuitesParams}")
http://localhost:8080/testqueryapi/rest/testRuns/;name=jaro/testSuites/;eyes=blue
The problem is that no PathParam was specified in the designated locations; we only have matrix params, so these segments are empty when the URI is normalized in UriTemplateNormalizer.normalize.
input --> /testRuns//testSuites/
output --> /testRuns/testSuites/
The double slash is correctly converted to single slash. To support this request, we would have to do something special to allow the empty path segment to not be normalized. See attached test patch (which goes on top of WINK-214 patch).
> tolerate empty path segments to support empty PathParams
> --------------------------------------------------------
>
> Key: WINK-216
> URL: https://issues.apache.org/jira/browse/WINK-216
> Project: Wink
> Issue Type: Improvement
> Components: Common
> Reporter: Mike Rheinheimer
>
> This is a followup to WINK-214.
> Not sure how exactly we want to approach this. There is a message on the user list requesting support for:
> @Path("/testRuns/{testRunsParams}/testSuites/{testSuitesParams}")
> http://localhost:8080/testqueryapi/rest/testRuns/;name=jaro/testSuites/;eyes=blue
> The problem is that no PathParam was specified in the designated locations; we only have matrix params, so these segments are empty when the URI is normalized in UriTemplateProcessor.normalizeUri.
> input --> /testRuns//testSuites/
> output --> /testRuns/testSuites/
> The double slash is correctly converted to single slash. To support this request, we would have to do something special to allow the empty path segment to not be normalized. See attached test patch (which goes on top of WINK-214 patch).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.