[jira] [Resolved] (HBASE-10138) incorrect or confusing test value is used in block caches

["Andrew Purtell (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HBASE-10138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Purtell resolved HBASE-10138.
------------------------------------

       Resolution: Fixed
    Fix Version/s: 0.98.0

Committed to 0.98 branch

> incorrect or confusing test value is used in block caches
> ---------------------------------------------------------
>
>                 Key: HBASE-10138
>                 URL: https://issues.apache.org/jira/browse/HBASE-10138
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Sergey Shelukhin
>            Assignee: Sergey Shelukhin
>             Fix For: 0.98.0, 0.99.0
>
>         Attachments: HBASE-10138.patch
>
>
> DEFAULT_BLOCKSIZE_SMALL is described as:
> {code}
>   // Make default block size for StoreFiles 8k while testing.  TODO: FIX!
>   // Need to make it 8k for testing.
>   public static final int DEFAULT_BLOCKSIZE_SMALL = 8 * 1024;
> {code}
> This value is used on production path in CacheConfig thru HStore/HRegion, and passed to various cache object.
> We should change it to actual block size, or if it is somehow by design at least we should clarify it and remove the comment. 



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)