You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iceberg.apache.org by sz...@apache.org on 2022/05/13 17:51:20 UTC
[iceberg] branch master updated: Core: Optimize when not deleting oldest metadata files after commit (#4651)
This is an automated email from the ASF dual-hosted git repository.
szehon pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/iceberg.git
The following commit(s) were added to refs/heads/master by this push:
new 241a0d0aa Core: Optimize when not deleting oldest metadata files after commit (#4651)
241a0d0aa is described below
commit 241a0d0aa57eab5fb787217d34ef06792aeb2196
Author: southernriver <so...@users.noreply.github.com>
AuthorDate: Sat May 14 01:51:16 2022 +0800
Core: Optimize when not deleting oldest metadata files after commit (#4651)
---
.../main/java/org/apache/iceberg/BaseMetastoreTableOperations.java | 5 ++---
.../main/java/org/apache/iceberg/hadoop/HadoopTableOperations.java | 5 ++---
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/core/src/main/java/org/apache/iceberg/BaseMetastoreTableOperations.java b/core/src/main/java/org/apache/iceberg/BaseMetastoreTableOperations.java
index 9e65ac87d..6cd6798a0 100644
--- a/core/src/main/java/org/apache/iceberg/BaseMetastoreTableOperations.java
+++ b/core/src/main/java/org/apache/iceberg/BaseMetastoreTableOperations.java
@@ -357,10 +357,9 @@ public abstract class BaseMetastoreTableOperations implements TableOperations {
TableProperties.METADATA_DELETE_AFTER_COMMIT_ENABLED,
TableProperties.METADATA_DELETE_AFTER_COMMIT_ENABLED_DEFAULT);
- Set<TableMetadata.MetadataLogEntry> removedPreviousMetadataFiles = Sets.newHashSet(base.previousFiles());
- removedPreviousMetadataFiles.removeAll(metadata.previousFiles());
-
if (deleteAfterCommit) {
+ Set<TableMetadata.MetadataLogEntry> removedPreviousMetadataFiles = Sets.newHashSet(base.previousFiles());
+ removedPreviousMetadataFiles.removeAll(metadata.previousFiles());
Tasks.foreach(removedPreviousMetadataFiles)
.noRetry().suppressFailureWhenFinished()
.onFailure((previousMetadataFile, exc) ->
diff --git a/core/src/main/java/org/apache/iceberg/hadoop/HadoopTableOperations.java b/core/src/main/java/org/apache/iceberg/hadoop/HadoopTableOperations.java
index f2347a9b9..cccdb8330 100644
--- a/core/src/main/java/org/apache/iceberg/hadoop/HadoopTableOperations.java
+++ b/core/src/main/java/org/apache/iceberg/hadoop/HadoopTableOperations.java
@@ -411,10 +411,9 @@ public class HadoopTableOperations implements TableOperations {
TableProperties.METADATA_DELETE_AFTER_COMMIT_ENABLED,
TableProperties.METADATA_DELETE_AFTER_COMMIT_ENABLED_DEFAULT);
- Set<TableMetadata.MetadataLogEntry> removedPreviousMetadataFiles = Sets.newHashSet(base.previousFiles());
- removedPreviousMetadataFiles.removeAll(metadata.previousFiles());
-
if (deleteAfterCommit) {
+ Set<TableMetadata.MetadataLogEntry> removedPreviousMetadataFiles = Sets.newHashSet(base.previousFiles());
+ removedPreviousMetadataFiles.removeAll(metadata.previousFiles());
Tasks.foreach(removedPreviousMetadataFiles)
.noRetry().suppressFailureWhenFinished()
.onFailure((previousMetadataFile, exc) ->