You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/08/26 19:27:20 UTC
[jira] [Work logged] (TS-4779) Remove SET_CLOSE_ON_EXEC #ifdef's
from socket code.
[ https://issues.apache.org/jira/browse/TS-4779?focusedWorklogId=27274&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-27274 ]
ASF GitHub Bot logged work on TS-4779:
--------------------------------------
Author: ASF GitHub Bot
Created on: 26/Aug/16 19:27
Start Date: 26/Aug/16 19:27
Worklog Time Spent: 10m
Work Description: GitHub user PSUdaemon opened a pull request:
https://github.com/apache/trafficserver/pull/934
TS-4779: Remove SET_CLOSE_ON_EXEC #ifdef's from socket code and make …
…CLOEXEC standard behavior.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/PSUdaemon/trafficserver ts-4779
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/934.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #934
----
commit 7debd2951fcb66e3f87f3802861f6f815c9f23ba
Author: Phil Sorber <so...@apache.org>
Date: 2016-08-26T19:25:44Z
TS-4779: Remove SET_CLOSE_ON_EXEC #ifdef's from socket code and make CLOEXEC standard behavior.
----
Issue Time Tracking
-------------------
Worklog Id: (was: 27274)
Time Spent: 10m
Remaining Estimate: 0h
> Remove SET_CLOSE_ON_EXEC #ifdef's from socket code.
> ---------------------------------------------------
>
> Key: TS-4779
> URL: https://issues.apache.org/jira/browse/TS-4779
> Project: Traffic Server
> Issue Type: Task
> Components: Network
> Reporter: Phil Sorber
> Assignee: Phil Sorber
> Fix For: 7.0.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> This appears to be set nowhere, and so effectively disables CLOEXEC. [~jpeach@apache.org] suggests we remove just the #ifdef's and thereby enable CLOEXEC. I agree with this approach, but it is a change in behavior.
> {noformat}
> $ grep -ir CLOSE_ON_EXEC
> iocore/net/UnixConnection.cc:#ifdef SET_CLOSE_ON_EXEC
> iocore/net/UnixConnection.cc:#ifdef SET_CLOSE_ON_EXEC
> iocore/net/Connection.cc:#ifdef SET_CLOSE_ON_EXEC
> iocore/net/Connection.cc:#ifdef SET_CLOSE_ON_EXEC
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)