[jira] [Comment Edited] (HBASE-14644) Region in transition metric is broken

["huaxiang sun (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-14644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15315296#comment-15315296 ] 

huaxiang sun edited comment on HBASE-14644 at 6/4/16 3:41 AM:
--------------------------------------------------------------

I am debugging the same issue and understand the root cause now. I am working on a patch.
[~eclark], is it ok with you? Thanks

Explain a little bit here:
in HMaster.java,
{code}
  protected void waitForMasterActive(){
    boolean tablesOnMaster = BaseLoadBalancer.tablesOnMaster(conf);
    while (!(tablesOnMaster && isActiveMaster)
        && !isStopped() && !isAborted()) {
      sleeper.sleep();
    }
  }
{code}
In branch-1, tablesOnMaster is false by default, so it blockes here. doMetrics() is never called.
In master, tablesOnMaster is true by default so it works by default.

My plan is to have a scheduleDoMetricsChore() in HRegionServer and let HMaster to override it, so HMaster can scedule a chore to call doMetrics() periodically. 

Please let me know if this is ok. Credit goes to [~mbertozzi] as well, I posted comments after discussion with him, thanks.


was (Author: huaxiang):
I am debugging the same issue and know the root cause now. I am working on a patch.
[~eclark], is it ok with you? Thanks

Explain a little bit here:
in HMaster.java,
{code}
  protected void waitForMasterActive(){
    boolean tablesOnMaster = BaseLoadBalancer.tablesOnMaster(conf);
    while (!(tablesOnMaster && isActiveMaster)
        && !isStopped() && !isAborted()) {
      sleeper.sleep();
    }
  }
{code}
In branch-1, tablesOnMaster is false by default, so it blockes here. doMetrics() is never called.
In master, tablesOnMaster is true by default so it works by default.

My plan is to have a scheduleDoMetricsChore() in HRegionServer and let HMaster to override it, so HMaster can scedule a chore to call doMetrics() periodically. 

Please let me know if this is ok. Credit goes to [~mbertozzi] as well, I posted comments after discussion with him, thanks.

> Region in transition metric is broken
> -------------------------------------
>
>                 Key: HBASE-14644
>                 URL: https://issues.apache.org/jira/browse/HBASE-14644
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Elliott Clark
>            Assignee: huaxiang sun
>
> ritCount stays 0 no matter what



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)