You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/08/06 04:12:40 UTC

[GitHub] [kafka] guozhangwang commented on a change in pull request #9094: KAFKA-10054: KIP-613, add TRACE-level e2e latency metrics

guozhangwang commented on a change in pull request #9094:
URL: https://github.com/apache/kafka/pull/9094#discussion_r466134186



##########
File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java
##########
@@ -154,15 +153,15 @@ public StreamTask(final TaskId id,
         for (final String terminalNodeName : topology.terminalNodes()) {
             e2eLatencySensors.put(
                 terminalNodeName,
-                TaskMetrics.e2ELatencySensor(threadId, taskId, terminalNodeName, RecordingLevel.INFO, streamsMetrics)
+                TaskMetrics.e2ELatencySensor(threadId, taskId, terminalNodeName, streamsMetrics)

Review comment:
       This is not introduced by this PR, but I'm wondering why we record the `maybeRecordE2ELatency` twice, once before the record is being processed and once when it reaches the sink node?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org