You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pdfbox.apache.org by grigoriy <gi...@git.apache.org> on 2018/08/10 14:48:36 UTC
[GitHub] pdfbox-jbig2 pull request #1: fix a memory leak in the cache
GitHub user grigoriy opened a pull request:
https://github.com/apache/pdfbox-jbig2/pull/1
fix a memory leak in the cache
Please see https://github.com/levigo/jbig2-imageio/issues/53.
I added a test which had been failing before this fix.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/grigoriy/pdfbox-jbig2 cache-fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/pdfbox-jbig2/pull/1.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1
----
commit 1795ee9a91123506d05351b590f4ce117b2f17de
Author: Grigoriy Alekseev <g....@...>
Date: 2018-08-10T17:09:31Z
fix a memory leak in the cache
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pdfbox.apache.org
For additional commands, e-mail: dev-help@pdfbox.apache.org
[GitHub] pdfbox-jbig2 issue #1: fix a memory leak in the cache
Posted by THausherr <gi...@git.apache.org>.
Github user THausherr commented on the issue:
https://github.com/apache/pdfbox-jbig2/pull/1
Please resubmit your proposal in JIRA. This is a read only mirror. Please do not reformat the code, that makes the changes bigger and harder to understand. I'd also prefer a solution that doesn't use an extra library. But having a test that fails is a great idea :-)
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pdfbox.apache.org
For additional commands, e-mail: dev-help@pdfbox.apache.org
[GitHub] pdfbox-jbig2 pull request #1: fix a memory leak in the cache
Posted by grigoriy <gi...@git.apache.org>.
Github user grigoriy closed the pull request at:
https://github.com/apache/pdfbox-jbig2/pull/1
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pdfbox.apache.org
For additional commands, e-mail: dev-help@pdfbox.apache.org
[GitHub] pdfbox-jbig2 pull request #1: fix a memory leak in the cache
Posted by hennejg <gi...@git.apache.org>.
Github user hennejg commented on a diff in the pull request:
https://github.com/apache/pdfbox-jbig2/pull/1#discussion_r209574636
--- Diff: pom.xml ---
@@ -220,14 +220,19 @@
<url>https://git-wip-us.apache.org/repos/asf?p=pdfbox-jbig2.git</url>
<tag>HEAD</tag>
</scm>
-
+
<dependencies>
- <dependency>
- <groupId>junit</groupId>
- <artifactId>junit</artifactId>
- <version>4.10</version>
- <scope>test</scope>
- </dependency>
+ <dependency>
+ <groupId>junit</groupId>
+ <artifactId>junit</artifactId>
+ <version>4.10</version>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>com.google.guava</groupId>
--- End diff --
I am not so sure that it is fine to just add a dependency on Guava here. Why nox fix the existing Implementation by adding weak keys?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pdfbox.apache.org
For additional commands, e-mail: dev-help@pdfbox.apache.org
[GitHub] pdfbox-jbig2 issue #1: fix a memory leak in the cache
Posted by grigoriy <gi...@git.apache.org>.
Github user grigoriy commented on the issue:
https://github.com/apache/pdfbox-jbig2/pull/1
Created a JIRA issue and rewritten without Guava: https://github.com/apache/pdfbox-jbig2/pull/2
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pdfbox.apache.org
For additional commands, e-mail: dev-help@pdfbox.apache.org