You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/04/15 22:03:07 UTC
[GitHub] [incubator-superset] graceguo-supercat opened a new pull request
#9550: [fix] dashboard filter scope bug
graceguo-supercat opened a new pull request #9550: [fix] dashboard filter scope bug
URL: https://github.com/apache/incubator-superset/pull/9550
### CATEGORY
Choose one
- [x] Bug Fix
- [ ] Enhancement (new features, refinement)
- [ ] Refactor
- [ ] Add tests
- [ ] Build / Development Environment
- [ ] Documentation
### SUMMARY
This PR is to fix a specific case in setting dashboard filter scope:
dashboard:
--- row 1: has a chart and a filter
--- row 2: has 2 tabs, but only some of charts in each tab that are applicable to filter
This is a bug fix in the algorithm so there is no UI change.
### TEST PLAN
Added unit test
### REVIEWERS
@ktmud @etr2460
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] lilila commented on issue #9550: [fix]
dashboard filter scope bug
Posted by GitBox <gi...@apache.org>.
lilila commented on issue #9550: [fix] dashboard filter scope bug
URL: https://github.com/apache/incubator-superset/pull/9550#issuecomment-615024490
@graceguo-supercat , the dashboard filter interface is great. Thank you for this.
However, it is **not possible to save edits from Safari** (it does nothing to click on save button) but it works well with Chrome.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] graceguo-supercat merged pull request #9550:
[fix] dashboard filter scope bug
Posted by GitBox <gi...@apache.org>.
graceguo-supercat merged pull request #9550: [fix] dashboard filter scope bug
URL: https://github.com/apache/incubator-superset/pull/9550
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] graceguo-supercat commented on issue #9550:
[fix] dashboard filter scope bug
Posted by GitBox <gi...@apache.org>.
graceguo-supercat commented on issue #9550: [fix] dashboard filter scope bug
URL: https://github.com/apache/incubator-superset/pull/9550#issuecomment-614934053
sorry for the confusion...i added an image to describe the problem. thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org