[jira] [Commented] (FLINK-3596) DataSet RelNode refactoring

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-3596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15187179#comment-15187179 ] 

ASF GitHub Bot commented on FLINK-3596:
---------------------------------------

GitHub user vasia opened a pull request:

    https://github.com/apache/flink/pull/1777

    [FLINK-3596] DataSet RelNode refactoring

    This PR refactors the current table API code so that
    
    - the intermediate flink relnode layer and the dataset rules are removed
    - code generation is moved from rules to DataSet nodes
    - unused DataSete nodes are removed
    - DataSetMap and DataSetReduce are merged into DataSetAggregate

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/vasia/flink refactor-table

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/1777.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1777
    
----
commit 249f7f5ecab79c6b5b214c37d7e2892f6efe3628
Author: vasia <va...@apache.org>
Date:   2016-03-08T16:29:32Z

    [FLINK-3596] DataSet RelNode refactoring
    
    - remove the intermediate flink relnode layer and the dataset rules
    
    - move code generation from rules to DataSet nodes
    
    - remove unused DataSete nodes
    
    - move code generation from join rule to DataSetJoin node
    
    - merge DataSetMap and DataSetReduce into  DataSetAggregate

----


> DataSet RelNode refactoring
> ---------------------------
>
>                 Key: FLINK-3596
>                 URL: https://issues.apache.org/jira/browse/FLINK-3596
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API
>    Affects Versions: 1.1.0
>            Reporter: Vasia Kalavri
>            Assignee: Vasia Kalavri
>
> After discussion with [~fhueske], [~chengxiang li], and [~twalthr], we have decided to make the following refactoring:
> - Make the DataSet RelNodes correspond to logical relational operators.
> - Move the code generation from the rules into the DataSet RelNodes.
> - Remove the Flink RelNode layer and have a 1-pass translation instead of a 2-pass translation as currently.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)