Re: Review Request 63949: RANGER-1898 - Simplify Knox plugin dependency management

[Colm O hEigeartaigh <co...@apache.org>]

> On Nov. 28, 2017, 6:39 a.m., bhavik patel wrote:
> > @Colm : Can you please confirm that audit to solr is working as expected? because you are also removing the ranger-plugins-audit dependency.
> 
> Colm O hEigeartaigh wrote:
>     The ranger-plugins-audit dependency is on the classpath via the agents-common module. However, I've removed that change just to make things easier to review - as my main goal is to simplify third-party dependencies in the poms.

For the record, I have verified that auditing to Solr works correctly.


- Colm


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63949/#review191998
-----------------------------------------------------------


On Nov. 28, 2017, 10:47 a.m., Colm O hEigeartaigh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63949/
> -----------------------------------------------------------
> 
> (Updated Nov. 28, 2017, 10:47 a.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-1898
>     https://issues.apache.org/jira/browse/RANGER-1898
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> This task is to simplify the dependency management for the Knox plugin for Ranger.
> 
> 
> Diffs
> -----
> 
>   knox-agent/pom.xml 52f15cd0 
> 
> 
> Diff: https://reviews.apache.org/r/63949/diff/3/
> 
> 
> Testing
> -------
> 
> Tested that the distribution ships the same jars as before. Also tested a use-case involving Ranger + Knox.
> 
> 
> Thanks,
> 
> Colm O hEigeartaigh
> 
>