You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/02/19 07:28:51 UTC

[GitHub] glasser opened a new pull request #7089: ParallelIndexSubTask: support ingestSegment in delegating factories

glasser opened a new pull request #7089: ParallelIndexSubTask: support ingestSegment in delegating factories
URL: https://github.com/apache/incubator-druid/pull/7089
 
 
   IndexTask had special-cased code to properly send a TaskToolbox to a
   IngestSegmentFirehoseFactory that's nested inside a CombiningFirehoseFactory,
   but ParallelIndexSubTask didn't.
   
   This change refactors IngestSegmentFirehoseFactory so that it doesn't need a
   TaskToolbox; it instead gets a CoordinatorClient and a SegmentLoaderFactory
   directly injected into it.
   
   Another goal of this PR is to make it possible for IngestSegmentFirehoseFactory
   to list data segments outside of connect() --- specifically, to make it a
   FiniteFirehoseFactory which can query the coordinator in order to calculate its
   splits. See #7048.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org