You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/01 23:45:17 UTC
[GitHub] [arrow-datafusion] tustvold opened a new pull request, #4070: Support Dictionary in InListExpr
tustvold opened a new pull request, #4070:
URL: https://github.com/apache/arrow-datafusion/pull/4070
_Draft as builds on #4057_
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #3936
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] NGA-TRAN commented on a diff in pull request #4070: Support Dictionary in InListExpr
Posted by GitBox <gi...@apache.org>.
NGA-TRAN commented on code in PR #4070:
URL: https://github.com/apache/arrow-datafusion/pull/4070#discussion_r1011015854
##########
datafusion/core/tests/sql/predicates.rs:
##########
@@ -428,8 +428,101 @@ async fn csv_in_set_test() -> Result<()> {
}
#[tokio::test]
-#[ignore]
-// https://github.com/apache/arrow-datafusion/issues/3936
+async fn in_list_string_dictionaries() -> Result<()> {
+ // let input = vec![Some("foo"), Some("bar"), None, Some("fazzz")]
+ let input = vec![Some("foo"), Some("bar"), Some("fazzz")]
+ .into_iter()
+ .collect::<DictionaryArray<Int32Type>>();
+
+ let batch = RecordBatch::try_from_iter(vec![("c1", Arc::new(input) as _)]).unwrap();
+
+ let ctx = SessionContext::new();
+ ctx.register_batch("test", batch)?;
+
+ let sql = "SELECT * FROM test WHERE c1 IN ('Bar')";
+ let actual = execute_to_batches(&ctx, sql).await;
+ let expected = vec!["++", "++"];
+ assert_batches_eq!(expected, &actual);
+
+ let sql = "SELECT * FROM test WHERE c1 IN ('foo')";
+ let actual = execute_to_batches(&ctx, sql).await;
+ let expected = vec!["+-----+", "| c1 |", "+-----+", "| foo |", "+-----+"];
+ assert_batches_eq!(expected, &actual);
+
+ let sql = "SELECT * FROM test WHERE c1 IN ('bar', 'foo')";
+ let actual = execute_to_batches(&ctx, sql).await;
+ let expected = vec![
+ "+-----+", "| c1 |", "+-----+", "| foo |", "| bar |", "+-----+",
+ ];
+ assert_batches_eq!(expected, &actual);
+
+ let sql = "SELECT * FROM test WHERE c1 IN ('Bar', 'foo')";
+ let actual = execute_to_batches(&ctx, sql).await;
+ let expected = vec!["+-----+", "| c1 |", "+-----+", "| foo |", "+-----+"];
+ assert_batches_eq!(expected, &actual);
+
+ let sql = "SELECT * FROM test WHERE c1 IN ('foo', 'Bar', 'fazzz')";
+ let actual = execute_to_batches(&ctx, sql).await;
+ let expected = vec![
+ "+-------+",
+ "| c1 |",
+ "+-------+",
+ "| foo |",
+ "| fazzz |",
+ "+-------+",
+ ];
+ assert_batches_eq!(expected, &actual);
+ Ok(())
+}
+
+#[tokio::test]
+async fn in_list_string_dictionaries_with_null() -> Result<()> {
+ let input = vec![Some("foo"), Some("bar"), None, Some("fazzz")]
+ .into_iter()
+ .collect::<DictionaryArray<Int32Type>>();
+
+ let batch = RecordBatch::try_from_iter(vec![("c1", Arc::new(input) as _)]).unwrap();
+
+ let ctx = SessionContext::new();
+ ctx.register_batch("test", batch)?;
+
+ let sql = "SELECT * FROM test WHERE c1 IN ('Bar')";
+ let actual = execute_to_batches(&ctx, sql).await;
+ let expected = vec!["++", "++"];
+ assert_batches_eq!(expected, &actual);
+
+ let sql = "SELECT * FROM test WHERE c1 IN ('foo')";
+ let actual = execute_to_batches(&ctx, sql).await;
+ let expected = vec!["+-----+", "| c1 |", "+-----+", "| foo |", "+-----+"];
+ assert_batches_eq!(expected, &actual);
+
+ let sql = "SELECT * FROM test WHERE c1 IN ('bar', 'foo')";
+ let actual = execute_to_batches(&ctx, sql).await;
+ let expected = vec![
+ "+-----+", "| c1 |", "+-----+", "| foo |", "| bar |", "+-----+",
+ ];
+ assert_batches_eq!(expected, &actual);
+
+ let sql = "SELECT * FROM test WHERE c1 IN ('Bar', 'foo')";
+ let actual = execute_to_batches(&ctx, sql).await;
+ let expected = vec!["+-----+", "| c1 |", "+-----+", "| foo |", "+-----+"];
+ assert_batches_eq!(expected, &actual);
+
+ let sql = "SELECT * FROM test WHERE c1 IN ('foo', 'Bar', 'fazzz')";
+ let actual = execute_to_batches(&ctx, sql).await;
+ let expected = vec![
+ "+-------+",
+ "| c1 |",
+ "+-------+",
+ "| foo |",
+ "| fazzz |",
+ "+-------+",
+ ];
+ assert_batches_eq!(expected, &actual);
+ Ok(())
+}
Review Comment:
🎉
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] tustvold commented on a diff in pull request #4070: Support Dictionary in InListExpr
Posted by GitBox <gi...@apache.org>.
tustvold commented on code in PR #4070:
URL: https://github.com/apache/arrow-datafusion/pull/4070#discussion_r1011006558
##########
datafusion/core/tests/sql/predicates.rs:
##########
@@ -440,7 +533,7 @@ async fn in_set_string_dictionaries() -> Result<()> {
let ctx = SessionContext::new();
ctx.register_batch("test", batch)?;
- let sql = "SELECT * FROM test WHERE c1 IN ('foo', 'Bar', 'fazz')";
+ let sql = "SELECT * FROM test WHERE c1 IN ('foo', 'Bar', 'fazzz')";
Review Comment:
This test was previously ignored, as it failed, and was actually wrong :laughing:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] ursabot commented on pull request #4070: Support Dictionary in InListExpr
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #4070:
URL: https://github.com/apache/arrow-datafusion/pull/4070#issuecomment-1301790287
Benchmark runs are scheduled for baseline = 8741372bd250338f90335ec49641adf733dbc243 and contender = 61429f839eb07bf50f36147d5b1d065194a45114. 61429f839eb07bf50f36147d5b1d065194a45114 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/67d8a62a98164dae9e0a4ec02bb99bf2...c0ee28eb79324e82bf127aa8ae88e5ff/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/38894409c5f6487a880208a7337ee06a...1247a805256b44c8a38a275c46e5519f/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/eae44661433244b48ba2ada552729c49...1f17037563224a41a00a38370fbf068e/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/08a06dd1b19b434aa03febc7ded8640b...96a0e6e609b04ad695719cbd7812119e/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] tustvold merged pull request #4070: Support Dictionary in InListExpr
Posted by GitBox <gi...@apache.org>.
tustvold merged PR #4070:
URL: https://github.com/apache/arrow-datafusion/pull/4070
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org