You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Laszlo Hornyak <la...@gmail.com> on 2013/10/06 20:38:23 UTC
Review Request 14514: MacAddress cleanup and test
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14514/
-----------------------------------------------------------
Review request for cloudstack.
Repository: cloudstack-git
Description
-------
- main method removed since it was not used by any other code
- commonted-out code removed
- Formatter close added
- commons IOUtils to close resources - somewhat shorter than the try-catch block
- tests added
Diffs
-----
utils/src/com/cloud/utils/net/MacAddress.java 15350c8
utils/test/com/cloud/utils/net/MacAddressTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/14514/diff/
Testing
-------
tests added
Thanks,
Laszlo Hornyak