You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Attila Doroszlai <ad...@hortonworks.com> on 2017/12/14 13:25:46 UTC
Review Request 64614: AMBARI-22164. Fix wrong assignment due to
leftover parameter name
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64614/
-----------------------------------------------------------
Review request for Ambari, Balázs Bence Sári, Jayush Luniya, Madhuvanthi Radhakrishnan, and Swapan Shridhar.
Bugs: AMBARI-22164
https://issues.apache.org/jira/browse/AMBARI-22164
Repository: ambari
Description
-------
`serviceDisplayName` was changed to `serviceName` in both sides of the assignment, but the parameter name was left as was, resulting in the member variable `serviceName` always being set to `null`.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentHostRequest.java ea082c66e128a30368d6be195f3ee270a08e8518
Diff: https://reviews.apache.org/r/64614/diff/1/
Testing
-------
Tested in blueprint deployment.
Thanks,
Attila Doroszlai
Re: Review Request 64614: AMBARI-22164. Fix wrong assignment due to
leftover parameter name
Posted by Balázs Bence Sári <bs...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64614/#review193915
-----------------------------------------------------------
Ship it!
Ship It!
- Balázs Bence Sári
On Dec. 14, 2017, 1:25 p.m., Attila Doroszlai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64614/
> -----------------------------------------------------------
>
> (Updated Dec. 14, 2017, 1:25 p.m.)
>
>
> Review request for Ambari, Balázs Bence Sári, Jayush Luniya, Madhuvanthi Radhakrishnan, and Swapan Shridhar.
>
>
> Bugs: AMBARI-22164
> https://issues.apache.org/jira/browse/AMBARI-22164
>
>
> Repository: ambari
>
>
> Description
> -------
>
> `serviceDisplayName` was changed to `serviceName` in both sides of the assignment, but the parameter name was left as was, resulting in the member variable `serviceName` always being set to `null`.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentHostRequest.java ea082c66e128a30368d6be195f3ee270a08e8518
>
>
> Diff: https://reviews.apache.org/r/64614/diff/1/
>
>
> Testing
> -------
>
> Tested in blueprint deployment.
>
>
> Thanks,
>
> Attila Doroszlai
>
>
Re: Review Request 64614: AMBARI-22164. Fix wrong assignment due to
leftover parameter name
Posted by Madhuvanthi Radhakrishnan <mr...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64614/#review193844
-----------------------------------------------------------
Ship it!
Ship It!
- Madhuvanthi Radhakrishnan
On Dec. 14, 2017, 1:25 p.m., Attila Doroszlai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64614/
> -----------------------------------------------------------
>
> (Updated Dec. 14, 2017, 1:25 p.m.)
>
>
> Review request for Ambari, Balázs Bence Sári, Jayush Luniya, Madhuvanthi Radhakrishnan, and Swapan Shridhar.
>
>
> Bugs: AMBARI-22164
> https://issues.apache.org/jira/browse/AMBARI-22164
>
>
> Repository: ambari
>
>
> Description
> -------
>
> `serviceDisplayName` was changed to `serviceName` in both sides of the assignment, but the parameter name was left as was, resulting in the member variable `serviceName` always being set to `null`.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentHostRequest.java ea082c66e128a30368d6be195f3ee270a08e8518
>
>
> Diff: https://reviews.apache.org/r/64614/diff/1/
>
>
> Testing
> -------
>
> Tested in blueprint deployment.
>
>
> Thanks,
>
> Attila Doroszlai
>
>