You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by rob05c <gi...@git.apache.org> on 2017/05/30 22:03:20 UTC

[GitHub] incubator-trafficcontrol pull request #627: Change Traffic Ops to hide sensi...

GitHub user rob05c opened a pull request:

    https://github.com/apache/incubator-trafficcontrol/pull/627

    Change Traffic Ops to hide sensitive data for non-db users

    Changes Traffic Ops to disallow LDAP users that don't exist in the
    database from seeing any sensitive information (essentially anything
    but graphs and general CDN-wide stats).

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rob05c/incubator-trafficcontrol to-ldapgraphsonly

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-trafficcontrol/pull/627.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #627
    
----
commit 7a5fd2a9fdb74d8fe54fd142526d4ceb80ecd5bf
Author: Robert Butts <ro...@gmail.com>
Date:   2017-05-30T21:59:39Z

    Change TO to hide sensitive data for non-db users
    
    Changes Traffic Ops to disallow LDAP users that don't exist in the
    database from seeing any sensitive information (essentially anything
    but graphs and general CDN-wide stats).

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol issue #627: Change Traffic Ops to hide sensitive da...

Posted by mitchell852 <gi...@git.apache.org>.
Github user mitchell852 commented on the issue:

    https://github.com/apache/incubator-trafficcontrol/pull/627
  
    This PR should be merged first - https://github.com/apache/incubator-trafficcontrol/pull/642
    
    Once that PR is merged, username will be added to access logs and that data can be used to determine who is logging in as ldap only and then a "local" user in the tm_user table can be created for those users....this will prevent those ldap only users from being totally cut off when this PR is merged...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol issue #627: Change Traffic Ops to hide sensitive da...

Posted by dangogh <gi...@git.apache.org>.
Github user dangogh commented on the issue:

    https://github.com/apache/incubator-trafficcontrol/pull/627
  
    conflicts with master -- please resolve these...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol issue #627: Change Traffic Ops to hide sensitive da...

Posted by rob05c <gi...@git.apache.org>.
Github user rob05c commented on the issue:

    https://github.com/apache/incubator-trafficcontrol/pull/627
  
    @mitchell852 Fixed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol issue #627: Change Traffic Ops to hide sensitive da...

Posted by rob05c <gi...@git.apache.org>.
Github user rob05c commented on the issue:

    https://github.com/apache/incubator-trafficcontrol/pull/627
  
    Fixed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #627: Change Traffic Ops to hide sensi...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-trafficcontrol/pull/627


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol issue #627: Change Traffic Ops to hide sensitive da...

Posted by mitchell852 <gi...@git.apache.org>.
Github user mitchell852 commented on the issue:

    https://github.com/apache/incubator-trafficcontrol/pull/627
  
    @rob05c - you should probably share this change with the dev or user email list to ensure that no unforeseen problems come of this change.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol issue #627: Change Traffic Ops to hide sensitive da...

Posted by mitchell852 <gi...@git.apache.org>.
Github user mitchell852 commented on the issue:

    https://github.com/apache/incubator-trafficcontrol/pull/627
  
    I can't get TO to build/start
    
    Couldn't load application from file "bin/../local/../script/cdn": Not a CODE reference at /src/github.com/apache/incubator-trafficcontrol/traffic_ops/app/lib/TrafficOpsRoutes.pm line 375, <$fn> line 1.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol issue #627: Change Traffic Ops to hide sensitive da...

Posted by mitchell852 <gi...@git.apache.org>.
Github user mitchell852 commented on the issue:

    https://github.com/apache/incubator-trafficcontrol/pull/627
  
    I'll try to check this out tomorrow. thanks @rob05c 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---