[GitHub] [flink-kubernetes-operator] morhidi commented on a diff in pull request #244: [FLINK-27520] Use admission-controller-framework in Webhook

[GitBox <gi...@apache.org>]

morhidi commented on code in PR #244:
URL: https://github.com/apache/flink-kubernetes-operator/pull/244#discussion_r883354595


##########
flink-kubernetes-webhook/pom.xml:
##########
@@ -36,6 +36,19 @@ under the License.
             <groupId>org.apache.flink</groupId>
             <artifactId>flink-kubernetes-operator</artifactId>
             <version>${project.version}</version>
+            <scope>provided</scope>
+        </dependency>
+
+        <dependency>
+            <groupId>io.javaoperatorsdk</groupId>
+            <artifactId>operator-framework-framework-core</artifactId>
+            <version>${operator.sdk.admission-controller.version}</version>
+            <exclusions>
+                <exclusion>
+                    <groupId>*</groupId>

Review Comment:
   The admission-controller-framework is depending on the `io.fabric8:openshift-client` that pulled in an older `io.fabric8:kubernetes-client`.  It had a collision with the newer `kubernetes-client` version that we put on the class path with the the operator-shaded jar.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org