[jira] [Commented] (KAFKA-5563) Clarify handling of connector name in config

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-5563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16256739#comment-16256739 ] 

ASF GitHub Bot commented on KAFKA-5563:
---------------------------------------

GitHub user soenkeliebau opened a pull request:

    https://github.com/apache/kafka/pull/4230

    KAFKA-5563: Moved comparison of connector name from url against name …

    …from config to own function and added check to create connector call.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/soenkeliebau/kafka KAFKA-5563

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/4230.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4230
    
----
commit 9722a70e235951f55b5e02dce14ab4c9bf3f95ae
Author: Soenke Liebau <so...@opencore.com>
Date:   2017-11-17T09:24:54Z

    KAFKA-5563: Moved comparison of connector name from url against name from config to own function and added check to create connector call.

----


> Clarify handling of connector name in config 
> ---------------------------------------------
>
>                 Key: KAFKA-5563
>                 URL: https://issues.apache.org/jira/browse/KAFKA-5563
>             Project: Kafka
>          Issue Type: Bug
>          Components: KafkaConnect
>    Affects Versions: 0.11.0.0
>            Reporter: Sönke Liebau
>            Assignee: Sönke Liebau
>            Priority: Minor
>
> The connector name is currently being stored in two places, once at the root level of the connector and once in the config:
> {code:java}
> {
> 	"name": "test",
> 	"config": {
> 		"connector.class": "org.apache.kafka.connect.tools.MockSinkConnector",
> 		"tasks.max": "3",
> 		"topics": "test-topic",
> 		"name": "test"
> 	},
> 	"tasks": [
> 		{
> 			"connector": "test",
> 			"task": 0
> 		}
> 	]
> }
> {code}
> If no name is provided in the "config" element, then the name from the root level is [copied there when the connector is being created|https://github.com/apache/kafka/blob/trunk/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/resources/ConnectorsResource.java#L95]. If however a name is provided in the config then it is not touched, which means it is possible to create a connector with a different name at the root level and in the config like this:
> {code:java}
> {
> 	"name": "test1",
> 	"config": {
> 		"connector.class": "org.apache.kafka.connect.tools.MockSinkConnector",
> 		"tasks.max": "3",
> 		"topics": "test-topic",
> 		"name": "differentname"
> 	},
> 	"tasks": [
> 		{
> 			"connector": "test1",
> 			"task": 0
> 		}
> 	]
> }
> {code}
> I am not aware of any issues that this currently causes, but it is at least confusing and probably not intended behavior and definitely bears potential for bugs, if different functions take the name from different places.
> Would it make sense to add a check to reject requests that provide different names in the request and the config section?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)