You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2022/08/20 19:28:08 UTC
[GitHub] [commons-lang] arturobernalg opened a new pull request, #940: Rename method and fix typo.
arturobernalg opened a new pull request, #940:
URL: https://github.com/apache/commons-lang/pull/940
Same as [b16050](https://github.com/apache/commons-lang/pull/939/commits/b160500b936998ab11cce9e7e1159bf5d296cbc6) but without breaking compatibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] arturobernalg commented on a diff in pull request #940: Rename method and fix typo.
Posted by GitBox <gi...@apache.org>.
arturobernalg commented on code in PR #940:
URL: https://github.com/apache/commons-lang/pull/940#discussion_r950850851
##########
src/main/java/org/apache/commons/lang3/time/DurationUtils.java:
##########
@@ -72,8 +72,28 @@ public static <T extends Throwable> void accept(final FailableBiConsumer<Long, I
*
* @param duration The duration to query.
* @return nanoseconds between 0 and 999,999.
+ * @deprecated Use {{@link #getNanosOfMilli(Duration)}.
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] garydgregory merged pull request #940: Rename method and fix typo.
Posted by GitBox <gi...@apache.org>.
garydgregory merged PR #940:
URL: https://github.com/apache/commons-lang/pull/940
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] arturobernalg commented on a diff in pull request #940: Rename method and fix typo.
Posted by GitBox <gi...@apache.org>.
arturobernalg commented on code in PR #940:
URL: https://github.com/apache/commons-lang/pull/940#discussion_r950740569
##########
src/test/java/org/apache/commons/lang3/time/DurationUtilsTest.java:
##########
@@ -38,16 +38,16 @@ public class DurationUtilsTest extends AbstractLangTest {
@Test
public void testGetNanosOfMilli() {
- assertEquals(0, DurationUtils.getNanosOfMiili(null));
- assertEquals(0, DurationUtils.getNanosOfMiili(Duration.ZERO));
- assertEquals(1, DurationUtils.getNanosOfMiili(Duration.ofNanos(1)));
- assertEquals(10, DurationUtils.getNanosOfMiili(Duration.ofNanos(10)));
- assertEquals(100, DurationUtils.getNanosOfMiili(Duration.ofNanos(100)));
- assertEquals(1_000, DurationUtils.getNanosOfMiili(Duration.ofNanos(1_000)));
- assertEquals(10_000, DurationUtils.getNanosOfMiili(Duration.ofNanos(10_000)));
- assertEquals(100_000, DurationUtils.getNanosOfMiili(Duration.ofNanos(100_000)));
- assertEquals(0, DurationUtils.getNanosOfMiili(Duration.ofNanos(1_000_000)));
- assertEquals(1, DurationUtils.getNanosOfMiili(Duration.ofNanos(1_000_001)));
+ assertEquals(0, DurationUtils.getNanosOfMilli(null));
Review Comment:
OK, done. Changed.
TY @garydgregory
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] garydgregory commented on a diff in pull request #940: Rename method and fix typo.
Posted by GitBox <gi...@apache.org>.
garydgregory commented on code in PR #940:
URL: https://github.com/apache/commons-lang/pull/940#discussion_r950733105
##########
src/test/java/org/apache/commons/lang3/time/DurationUtilsTest.java:
##########
@@ -38,16 +38,16 @@ public class DurationUtilsTest extends AbstractLangTest {
@Test
public void testGetNanosOfMilli() {
- assertEquals(0, DurationUtils.getNanosOfMiili(null));
- assertEquals(0, DurationUtils.getNanosOfMiili(Duration.ZERO));
- assertEquals(1, DurationUtils.getNanosOfMiili(Duration.ofNanos(1)));
- assertEquals(10, DurationUtils.getNanosOfMiili(Duration.ofNanos(10)));
- assertEquals(100, DurationUtils.getNanosOfMiili(Duration.ofNanos(100)));
- assertEquals(1_000, DurationUtils.getNanosOfMiili(Duration.ofNanos(1_000)));
- assertEquals(10_000, DurationUtils.getNanosOfMiili(Duration.ofNanos(10_000)));
- assertEquals(100_000, DurationUtils.getNanosOfMiili(Duration.ofNanos(100_000)));
- assertEquals(0, DurationUtils.getNanosOfMiili(Duration.ofNanos(1_000_000)));
- assertEquals(1, DurationUtils.getNanosOfMiili(Duration.ofNanos(1_000_001)));
+ assertEquals(0, DurationUtils.getNanosOfMilli(null));
Review Comment:
Hi @arturobernalg
Thank you for your PR.
We have to test both calls explicitly, so your best bet is to clone the test method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] garydgregory commented on a diff in pull request #940: Rename method and fix typo.
Posted by GitBox <gi...@apache.org>.
garydgregory commented on code in PR #940:
URL: https://github.com/apache/commons-lang/pull/940#discussion_r950841453
##########
src/main/java/org/apache/commons/lang3/time/DurationUtils.java:
##########
@@ -72,8 +72,28 @@ public static <T extends Throwable> void accept(final FailableBiConsumer<Long, I
*
* @param duration The duration to query.
* @return nanoseconds between 0 and 999,999.
+ * @deprecated Use {{@link #getNanosOfMilli(Duration)}.
Review Comment:
Fix `{'
##########
src/main/java/org/apache/commons/lang3/time/DurationUtils.java:
##########
@@ -72,8 +72,28 @@ public static <T extends Throwable> void accept(final FailableBiConsumer<Long, I
*
* @param duration The duration to query.
* @return nanoseconds between 0 and 999,999.
+ * @deprecated Use {{@link #getNanosOfMilli(Duration)}.
Review Comment:
Fix `{`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] codecov-commenter commented on pull request #940: Rename method and fix typo.
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #940:
URL: https://github.com/apache/commons-lang/pull/940#issuecomment-1221392957
# [Codecov](https://codecov.io/gh/apache/commons-lang/pull/940?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#940](https://codecov.io/gh/apache/commons-lang/pull/940?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bfbf40f) into [master](https://codecov.io/gh/apache/commons-lang/commit/ef68684cb3d49888a0b8a7c94699afb9c56f63d3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ef68684) will **increase** coverage by `0.00%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head bfbf40f differs from pull request most recent head 825bc55. Consider uploading reports for the commit 825bc55 to get more accurate results
```diff
@@ Coverage Diff @@
## master #940 +/- ##
=========================================
Coverage 92.01% 92.02%
- Complexity 7435 7437 +2
=========================================
Files 189 189
Lines 15751 15752 +1
Branches 2961 2961
=========================================
+ Hits 14493 14495 +2
Misses 672 672
+ Partials 586 585 -1
```
| [Impacted Files](https://codecov.io/gh/apache/commons-lang/pull/940?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...a/org/apache/commons/lang3/time/DurationUtils.java](https://codecov.io/gh/apache/commons-lang/pull/940/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvbGFuZzMvdGltZS9EdXJhdGlvblV0aWxzLmphdmE=) | `85.18% <100.00%> (+0.56%)` | :arrow_up: |
| [...ache/commons/lang3/concurrent/LazyInitializer.java](https://codecov.io/gh/apache/commons-lang/pull/940/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvbGFuZzMvY29uY3VycmVudC9MYXp5SW5pdGlhbGl6ZXIuamF2YQ==) | `100.00% <0.00%> (+9.09%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org