You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by Raghav Gautam <ra...@apache.org> on 2014/12/18 23:56:40 UTC

Review Request 29209: enable and fix feedAclUpdate and processAclUpdate tests

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29209/
-----------------------------------------------------------

Review request for Falcon.


Bugs: falcon-955
    https://issues.apache.org/jira/browse/falcon-955


Repository: falcon-git


Description
-------

enable and fix feedAclUpdate and processAclUpdate tests


Diffs
-----

  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/enumsAndConstants/MerlinConstants.java 10cddf0 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/FeedAclTest.java 74275ab 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/ProcessAclTest.java f5fcdee 

Diff: https://reviews.apache.org/r/29209/diff/


Testing
-------

The test does not pass because for falcon-959.


Thanks,

Raghav Gautam


Re: Review Request 29209: enable and fix feedAclUpdate and processAclUpdate tests

Posted by Paul Isaychuk <pi...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29209/#review65760
-----------------------------------------------------------

Ship it!


Ship It!

- Paul Isaychuk


On Dec. 18, 2014, 10:56 p.m., Raghav Gautam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29209/
> -----------------------------------------------------------
> 
> (Updated Dec. 18, 2014, 10:56 p.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: falcon-955
>     https://issues.apache.org/jira/browse/falcon-955
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> enable and fix feedAclUpdate and processAclUpdate tests
> 
> 
> Diffs
> -----
> 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/enumsAndConstants/MerlinConstants.java 10cddf0 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/FeedAclTest.java 74275ab 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/ProcessAclTest.java f5fcdee 
> 
> Diff: https://reviews.apache.org/r/29209/diff/
> 
> 
> Testing
> -------
> 
> The test does not pass because for falcon-959.
> 
> 
> Thanks,
> 
> Raghav Gautam
> 
>


Re: Review Request 29209: enable and fix feedAclUpdate and processAclUpdate tests

Posted by Paul Isaychuk <pi...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29209/#review65758
-----------------------------------------------------------



falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/ProcessAclTest.java
<https://reviews.apache.org/r/29209/#comment109000>

    Minor typo: 'process' seems to be intended in comment.


- Paul Isaychuk


On Dec. 18, 2014, 10:56 p.m., Raghav Gautam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29209/
> -----------------------------------------------------------
> 
> (Updated Dec. 18, 2014, 10:56 p.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: falcon-955
>     https://issues.apache.org/jira/browse/falcon-955
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> enable and fix feedAclUpdate and processAclUpdate tests
> 
> 
> Diffs
> -----
> 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/enumsAndConstants/MerlinConstants.java 10cddf0 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/FeedAclTest.java 74275ab 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/ProcessAclTest.java f5fcdee 
> 
> Diff: https://reviews.apache.org/r/29209/diff/
> 
> 
> Testing
> -------
> 
> The test does not pass because for falcon-959.
> 
> 
> Thanks,
> 
> Raghav Gautam
> 
>