[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #135: Use big-endian byte order for UUIDs in Conversions

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #135: Use big-endian byte order for UUIDs in Conversions
URL: https://github.com/apache/incubator-iceberg/pull/135#discussion_r267027127
 
 

 ##########
 File path: api/src/main/java/com/netflix/iceberg/types/Conversions.java
 ##########
 @@ -98,7 +99,7 @@ public static ByteBuffer toByteBuffer(Type type, Object value) {
         }
       case UUID:
         UUID uuid = (UUID) value;
-        return ByteBuffer.allocate(16).order(ByteOrder.LITTLE_ENDIAN)
+        return ByteBuffer.allocate(16).order(ByteOrder.BIG_ENDIAN)
 
 Review comment:
   Just to be sure, the `putLong` calls are in the right order, correct?
   
   Could you add a test that validates the UUID example from the spec? I want to make sure we get this right.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org