[GitHub] [iceberg] rdblue commented on a diff in pull request #7387: Hive: Add engine name/version to EnvironmentContext

["rdblue (via GitHub)" <gi...@apache.org>]

rdblue commented on code in PR #7387:
URL: https://github.com/apache/iceberg/pull/7387#discussion_r1172869672


##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##########
@@ -108,6 +110,9 @@ public void initialize(String inputName, Map<String, String> properties) {
             : CatalogUtil.loadFileIO(fileIOImpl, properties, conf);
 
     this.clients = new CachedClientPool(conf, properties);
+
+    EnvironmentContext.put(EnvironmentContext.ENGINE_NAME, "hive");
+    EnvironmentContext.put(EnvironmentContext.ENGINE_VERSION, HiveVersionInfo.getVersion());

Review Comment:
   This cannot be committed.
   
   @singhpk234 is correct. Using HiveCatalog does not signal that the engine is Hive.
   
   We need to find another place to set the engine to Hive, in code that is associated with the engine not the metastore.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org