You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by David McLaughlin <da...@dmclaughlin.com> on 2018/02/03 00:27:12 UTC
Review Request 65494: Add task page to Scheduler UI
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65494/
-----------------------------------------------------------
Review request for Aurora, Kai Huang, Reza Motamedi, and Santhosh Kumar Shanmugham.
Repository: aurora
Description
-------
Add task page to Scheduler UI. I haven't created any inbound links to this yet because there isn't any really useful information, but we have a need to permalink to tasks from outside the Scheduler so right now this scratches that itch.
If anyone has ideas about where we can add permalinks or inbound clicks.. let me know! In the future we could maybe bring some of the Observer stuff into this page and make it really useful.
Diffs
-----
ui/src/main/js/components/Breadcrumb.js 76c62709cf3ebf76e74e08573bc8b245a45d5fe9
ui/src/main/js/components/TaskStatus.js 2e5a2b46121d6cc7c80c6d7589803a10973b5c1b
ui/src/main/js/components/__tests__/Breadcrumb-test.js 47f7afb29b9192e214040097dbfee2ff7f7e29ed
ui/src/main/js/index.js 9f94d4bd6f649d74bdd9c3aa99783e01cae25d93
ui/src/main/js/pages/Task.js PRE-CREATION
ui/src/main/js/pages/__tests__/Task-test.js PRE-CREATION
ui/src/main/sass/components/_instance-page.scss 1da87dcb0f66c258179295b23bda5c895bf5308f
Diff: https://reviews.apache.org/r/65494/diff/1/
Testing
-------
./gradlew ui:test
See screenshot for Vagrant test.
File Attachments
----------------
Screen Shot 2018-02-02 at 4.22.16 PM.png
https://reviews.apache.org/media/uploaded/files/2018/02/03/588521b3-6014-4e63-aa4c-8389d4ed44e3__Screen_Shot_2018-02-02_at_4.22.16_PM.png
Thanks,
David McLaughlin
Re: Review Request 65494: Add task page to Scheduler UI
Posted by Santhosh Kumar Shanmugham <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65494/#review196813
-----------------------------------------------------------
Ship it!
LGTM.
I looked briefly at the Observer code and it should be easy to expose the thermos state as JSON, which can be fit into the scheduler UI. Happy to help with the Observer changes.
- Santhosh Kumar Shanmugham
On Feb. 2, 2018, 4:27 p.m., David McLaughlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65494/
> -----------------------------------------------------------
>
> (Updated Feb. 2, 2018, 4:27 p.m.)
>
>
> Review request for Aurora, Kai Huang, Reza Motamedi, and Santhosh Kumar Shanmugham.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add task page to Scheduler UI. I haven't created any inbound links to this yet because there isn't any really useful information, but we have a need to permalink to tasks from outside the Scheduler so right now this scratches that itch.
>
> If anyone has ideas about where we can add permalinks or inbound clicks.. let me know! In the future we could maybe bring some of the Observer stuff into this page and make it really useful.
>
>
> Diffs
> -----
>
> ui/src/main/js/components/Breadcrumb.js 76c62709cf3ebf76e74e08573bc8b245a45d5fe9
> ui/src/main/js/components/TaskStatus.js 2e5a2b46121d6cc7c80c6d7589803a10973b5c1b
> ui/src/main/js/components/__tests__/Breadcrumb-test.js 47f7afb29b9192e214040097dbfee2ff7f7e29ed
> ui/src/main/js/index.js 9f94d4bd6f649d74bdd9c3aa99783e01cae25d93
> ui/src/main/js/pages/Task.js PRE-CREATION
> ui/src/main/js/pages/__tests__/Task-test.js PRE-CREATION
> ui/src/main/sass/components/_instance-page.scss 1da87dcb0f66c258179295b23bda5c895bf5308f
>
>
> Diff: https://reviews.apache.org/r/65494/diff/1/
>
>
> Testing
> -------
>
> ./gradlew ui:test
>
> See screenshot for Vagrant test.
>
>
> File Attachments
> ----------------
>
> Screen Shot 2018-02-02 at 4.22.16 PM.png
> https://reviews.apache.org/media/uploaded/files/2018/02/03/588521b3-6014-4e63-aa4c-8389d4ed44e3__Screen_Shot_2018-02-02_at_4.22.16_PM.png
>
>
> Thanks,
>
> David McLaughlin
>
>
Re: Review Request 65494: Add task page to Scheduler UI
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65494/#review196773
-----------------------------------------------------------
Master (f088032) is red with this patch.
./build-support/jenkins/build.sh
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
--------------- Captured log call ----------------
health_checker.py 167 INFO INFO] Reached consecutive success limit.
health_checker.py 143 WARNING WARN] Health check failure: failure-4
health_checker.py 159 WARNING WARN] Reached consecutive failure limit.
health_checker.py 143 WARNING WARN] Health check failure: failure-5
health_checker.py 159 WARNING WARN] Reached consecutive failure limit.
2 failed, 798 passed, 6 skipped in 346.91 seconds
FAILURE
Waiting for background workers to finish.
01:08:34 06:26 [complete]
FAILURE
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Feb. 3, 2018, 12:27 a.m., David McLaughlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65494/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2018, 12:27 a.m.)
>
>
> Review request for Aurora, Kai Huang, Reza Motamedi, and Santhosh Kumar Shanmugham.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add task page to Scheduler UI. I haven't created any inbound links to this yet because there isn't any really useful information, but we have a need to permalink to tasks from outside the Scheduler so right now this scratches that itch.
>
> If anyone has ideas about where we can add permalinks or inbound clicks.. let me know! In the future we could maybe bring some of the Observer stuff into this page and make it really useful.
>
>
> Diffs
> -----
>
> ui/src/main/js/components/Breadcrumb.js 76c62709cf3ebf76e74e08573bc8b245a45d5fe9
> ui/src/main/js/components/TaskStatus.js 2e5a2b46121d6cc7c80c6d7589803a10973b5c1b
> ui/src/main/js/components/__tests__/Breadcrumb-test.js 47f7afb29b9192e214040097dbfee2ff7f7e29ed
> ui/src/main/js/index.js 9f94d4bd6f649d74bdd9c3aa99783e01cae25d93
> ui/src/main/js/pages/Task.js PRE-CREATION
> ui/src/main/js/pages/__tests__/Task-test.js PRE-CREATION
> ui/src/main/sass/components/_instance-page.scss 1da87dcb0f66c258179295b23bda5c895bf5308f
>
>
> Diff: https://reviews.apache.org/r/65494/diff/1/
>
>
> Testing
> -------
>
> ./gradlew ui:test
>
> See screenshot for Vagrant test.
>
>
> File Attachments
> ----------------
>
> Screen Shot 2018-02-02 at 4.22.16 PM.png
> https://reviews.apache.org/media/uploaded/files/2018/02/03/588521b3-6014-4e63-aa4c-8389d4ed44e3__Screen_Shot_2018-02-02_at_4.22.16_PM.png
>
>
> Thanks,
>
> David McLaughlin
>
>
Re: Review Request 65494: Add task page to Scheduler UI
Posted by Reza Motamedi <re...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65494/#review196818
-----------------------------------------------------------
Ship it!
Ship It!
- Reza Motamedi
On Feb. 3, 2018, 12:27 a.m., David McLaughlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65494/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2018, 12:27 a.m.)
>
>
> Review request for Aurora, Kai Huang, Reza Motamedi, and Santhosh Kumar Shanmugham.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add task page to Scheduler UI. I haven't created any inbound links to this yet because there isn't any really useful information, but we have a need to permalink to tasks from outside the Scheduler so right now this scratches that itch.
>
> If anyone has ideas about where we can add permalinks or inbound clicks.. let me know! In the future we could maybe bring some of the Observer stuff into this page and make it really useful.
>
>
> Diffs
> -----
>
> ui/src/main/js/components/Breadcrumb.js 76c62709cf3ebf76e74e08573bc8b245a45d5fe9
> ui/src/main/js/components/TaskStatus.js 2e5a2b46121d6cc7c80c6d7589803a10973b5c1b
> ui/src/main/js/components/__tests__/Breadcrumb-test.js 47f7afb29b9192e214040097dbfee2ff7f7e29ed
> ui/src/main/js/index.js 9f94d4bd6f649d74bdd9c3aa99783e01cae25d93
> ui/src/main/js/pages/Task.js PRE-CREATION
> ui/src/main/js/pages/__tests__/Task-test.js PRE-CREATION
> ui/src/main/sass/components/_instance-page.scss 1da87dcb0f66c258179295b23bda5c895bf5308f
>
>
> Diff: https://reviews.apache.org/r/65494/diff/1/
>
>
> Testing
> -------
>
> ./gradlew ui:test
>
> See screenshot for Vagrant test.
>
>
> File Attachments
> ----------------
>
> Screen Shot 2018-02-02 at 4.22.16 PM.png
> https://reviews.apache.org/media/uploaded/files/2018/02/03/588521b3-6014-4e63-aa4c-8389d4ed44e3__Screen_Shot_2018-02-02_at_4.22.16_PM.png
>
>
> Thanks,
>
> David McLaughlin
>
>
Re: Review Request 65494: Add task page to Scheduler UI
Posted by Kai Huang <te...@hotmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65494/#review196780
-----------------------------------------------------------
Ship it!
Ship It!
- Kai Huang
On Feb. 3, 2018, 12:27 a.m., David McLaughlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65494/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2018, 12:27 a.m.)
>
>
> Review request for Aurora, Kai Huang, Reza Motamedi, and Santhosh Kumar Shanmugham.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add task page to Scheduler UI. I haven't created any inbound links to this yet because there isn't any really useful information, but we have a need to permalink to tasks from outside the Scheduler so right now this scratches that itch.
>
> If anyone has ideas about where we can add permalinks or inbound clicks.. let me know! In the future we could maybe bring some of the Observer stuff into this page and make it really useful.
>
>
> Diffs
> -----
>
> ui/src/main/js/components/Breadcrumb.js 76c62709cf3ebf76e74e08573bc8b245a45d5fe9
> ui/src/main/js/components/TaskStatus.js 2e5a2b46121d6cc7c80c6d7589803a10973b5c1b
> ui/src/main/js/components/__tests__/Breadcrumb-test.js 47f7afb29b9192e214040097dbfee2ff7f7e29ed
> ui/src/main/js/index.js 9f94d4bd6f649d74bdd9c3aa99783e01cae25d93
> ui/src/main/js/pages/Task.js PRE-CREATION
> ui/src/main/js/pages/__tests__/Task-test.js PRE-CREATION
> ui/src/main/sass/components/_instance-page.scss 1da87dcb0f66c258179295b23bda5c895bf5308f
>
>
> Diff: https://reviews.apache.org/r/65494/diff/1/
>
>
> Testing
> -------
>
> ./gradlew ui:test
>
> See screenshot for Vagrant test.
>
>
> File Attachments
> ----------------
>
> Screen Shot 2018-02-02 at 4.22.16 PM.png
> https://reviews.apache.org/media/uploaded/files/2018/02/03/588521b3-6014-4e63-aa4c-8389d4ed44e3__Screen_Shot_2018-02-02_at_4.22.16_PM.png
>
>
> Thanks,
>
> David McLaughlin
>
>